Conversation
nick1udwig
requested changes
Feb 13, 2024
Member
nick1udwig
left a comment
There was a problem hiding this comment.
A few comments:
- Let's point this at
developbranch. - I'd prefer to revert db604ea
There are a number of places in the code where rustfmt makes it less readable imo, e.g.
https://github.com/kinode-dao/kit/blob/db604eaf5241acea442d29fa3d38830fae8b9617/src/build/mod.rs#L112-L116
whereis changed to.stdout(if verbose { Stdio::inherit() } else { Stdio::null() }).stdout(if verbose { Stdio::inherit() } else { Stdio::null() }) - Let's lock in a
revforkinode_process_lib: it can point to a branch. I like to be able to test PRs.
| @@ -1,3 +1,4 @@ | |||
| use kinode_process_lib::kernel_types::Erc721Metadata; | |||
Member
There was a problem hiding this comment.
Would prefer this be in a third grouping of imports after the one starting with serde_json. The general convention I like to follow is:
- Alphabetized within a group.
- First group: "stdlibs"
- Second group: imported libs/crates
- Third group: our libs/crates
and so on: from more "general"/widely distributed to more "specific"/local.
Member
There was a problem hiding this comment.
Sorry, one more down in its own grp, e.g.
use std::foo;
...
use serde_json::bar;
...
use kinode_process_lib::baz;
...
use super::inject_message;
...
added 4 commits
February 13, 2024 16:50
This reverts commit db604ea. revert
Member
|
@tadad I realize I should have asked for a docs PR associated with this one before merge. I've opened hyperware-ai/hyperware-book#132 to track it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.