Conversation
nick1udwig
approved these changes
Feb 20, 2024
Member
nick1udwig
left a comment
nick1udwig
left a comment
There was a problem hiding this comment.
Left a nit; otherwise LGTM 👍
| } else { | ||
| trial - mean | ||
| } | ||
| }) / number_trials as u128; |
Member
There was a problem hiding this comment.
nit: The above was much more readable to me as the one-liner
ad + if mean >= trial { mean - trial } else { trial - mean }
Contributor
Author
There was a problem hiding this comment.
rustfmt automatically puts it on 4 lines :(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Recursive fibonacci impl good for testing perf, bad for proving (which we wanna use this template for!)
Solution
Swap fib function to iterative
Docs Update
N/A
Notes