Skip to content

Conversation

@nick1udwig
Copy link
Member

Problem

{A brief description of the problem, along with necessary context.}

Solution

{A brief description of how you solved the problem.}

Docs Update

Corresponding docs PR

Notes

{Any other information useful for reviewers.}

Copy link
Member Author

@nick1udwig nick1udwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bindings.rs is largely copied from hypermap.rs

I'm wondering if we can't remove all the dupe'd code and bring whatever unique functionality in from bindings.rs to hypermap.rs

E.g., we obviously need some constants: bring those in.

It looks like we need the ability to hit binding-cacher rather than hypermap-cacher: seems like we can just factor out a more general version of this function that takes an argument of what processid to hit, and then define a hypermap and a binding version that wraps that function, passing in the appropriate processid

@dolled-possum
Copy link
Contributor

The change that affects the UI path in src/hyperapp.rs is a mystery to me, but nothing I tried to build with kit (develop branch, --hyperapp flag) would successfully build without it.

Base automatically changed from develop to main November 27, 2025 05:48
@nick1udwig nick1udwig changed the base branch from main to develop November 27, 2025 05:50
@dolled-possum dolled-possum marked this pull request as ready for review December 1, 2025 21:46
pub mod contract {
use alloy_sol_macro::sol;

sol! {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now updated.

@dolled-possum
Copy link
Contributor

I also added a new wait_for_process_ready fn that allows us to generically hold and wait for other processes, looking for particular response statuses to know it's safe to proceed.

Copy link
Member Author

@nick1udwig nick1udwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ⚡

@nick1udwig nick1udwig merged commit 8cc0079 into develop Dec 2, 2025
1 check passed
@nick1udwig nick1udwig deleted the dw/hmap-binding-cacher branch December 2, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants