ICNS integration #124
Merged
ICNS integration #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyramation
reviewed
Dec 25, 2022
packages/react/package.json
Outdated
| "@babel/runtime": "7.11.2", | ||
| "@chakra-ui/react": "2.4.3", | ||
| "@cosmos-kit/core": "^0.27.13", | ||
| "@cosmos-kit/icns": "^0.0.1", |
There was a problem hiding this comment.
I think adding @cosmos-kit/icns inside of @cosmos-kit/react is sort of like adding it to the core... is there a way to move this logic in the @cosmos-kit/icns package?
Ideally we can load everything as a plugin w/o modifying @cosmos-kit/core or @cosmos-kit/react
There was a problem hiding this comment.
Make sense, I will move the logic!
|
Fixed according to the feedback, lmk if there is anything else to update @pyramation |
pyramation
reviewed
Dec 29, 2022
| @@ -0,0 +1,75 @@ | |||
| import { CosmWasmClient } from '@cosmjs/cosmwasm-stargate'; | |||
| import { useChain, useWallet } from '@cosmos-kit/react'; | |||
| import useSWR from 'swr'; | |||
There was a problem hiding this comment.
hey, what is swr needed for?
There was a problem hiding this comment.
seems like you have already figured out :)
pyramation
reviewed
Dec 29, 2022
| const { data, error, isLoading } = useSWR( | ||
| `${swrNamespace}/${address}`, | ||
| async () => { | ||
| const client = await osmosis.getCosmWasmClient(); |
There was a problem hiding this comment.
this is the way! thanks for using the right tools for the job ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ICNS integration for cosmos-kit. This PR contains
@cosmos-kit/icnsas a separated packagereactpackage, let me know if it makes more sense to separate the hook logic out as it's own package (eg.@cosmos-kit/icns-react) or moved to@cosmos-kit/icnsThe goal is to make it modular and not imposed itself as a default name service so developer can choose what they want.