Skip to content

Conversation

@Zetazzz
Copy link
Collaborator

@Zetazzz Zetazzz commented Jul 31, 2023

added setDefaultEnumTo0(default: false):

true: enum empty value would be 0
false: -1(value for enum unrecognized)

added setDefaultOtherTypesToUndefined(default: false):

true: Timestamp,Duration,Any,Coin empty would be undefined.
false: using fromPartial to get an empty obj

@Zetazzz Zetazzz marked this pull request as ready for review July 31, 2023 23:36
@Zetazzz Zetazzz changed the title Apply env flag Apply flags for default values Aug 1, 2023
Copy link
Collaborator

@pyramation pyramation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you can build the types properly, LGTM!

@Zetazzz Zetazzz merged commit eaebc48 into main Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants