Skip to content

Conversation

@Zetazzz
Copy link
Collaborator

@Zetazzz Zetazzz commented Aug 18, 2023

The root cause of type name containing dots is:

  1. Only Entry objects(type generated for hash type, e.g. EvalRequest_BindingsEntry) have this problem
  2. When parsing types for Entry objects, previous logic confused between type(should contain dots) and parsedType(the type after all dots and without dots) when creating ProtoField.

So mainly only the parsing logic changed.

I added a test in fixtures called misc, this folder can be used to test some result of certain cases of proto files.

Since this's a bug, I guess output1 and output2 should also be changed.

There're some format changes happened in helpers and index of output1 and 2, no logic changes for those files, so I guess it's also fine to include them.

@Zetazzz Zetazzz marked this pull request as ready for review August 18, 2023 10:00
@Zetazzz Zetazzz merged commit ec19dfe into main Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants