-
Notifications
You must be signed in to change notification settings - Fork 712
Upgraded dependencies, merged some features, bugfixes #335
Conversation
…holder when input range does not have a value
|
Great PR 🙏. Any timeline on merging it? |
|
It would be great! 🎉 Amazing work @onurkerimov! I did not dare to update this package and Until this is merged, I am doing (I see this one resolves my own PR #245! 😃) |
|
@mkg0 @burakcan @mortargrind @keremciu @mefallit Any timeline on merging it? Thanks in advance!!! |
|
@burakcan Do you have access to merge the PR? |
|
@rmkanda I have but I think it's better to leave that to @onurkerimov |
|
Today we are going to merge this. |
|
@onurkerimov It's an awesome upgrade, but I have two things on my mind. First, you mention in the Secondly, I see the package has not been published to npm as of yet. Given the version number could be improved, it may be a good thing. I suggest you bump to 2, and THEN publish to npm as Again, AMAZING work! 🎉 UPDATE:
Given this, 1.1.0 is just a plain mistake! UPDATE 2: I may have moved on this too fast... I see the "latest" until now was 0.x.x, so technically 1.1.0 was correct, but why the x.1.x change, if there was never a 1.0.0? |
|
Maybe we can tag this as 1.0.0? 1.1.0 feels a bit random given there was never a 1.0.0 - unless you had internal releases. (I left the company long ago so I'm not familiar with the latest situation) @onurkerimov added you to the npm package so you can publish a new version. As a personal note; thanks to everyone who spent time working on this or used the library. react-date-range was my onboarding project when I first joined Adphorus :) It's exciting to see how this project grew to be what it is today. |
WIP
Demo Site
Types of changes
Description
React 16 migration and removal of deprecated methods, refactoring #331
Migrate date-fns into new version (2.8.1) #315
date-fns is now loaded as a peerDependency #294
Pass newly added locales directly from date-fns #245
Migrate all devDependencies into new versions
Github pages uses react-styleguidist for examples
Remove Webpack configuration file move completely to react-styleguidist
Modify Babel configuration to stay up to date
Remove deprecated vscode settings
Add Prettier-Eslint integration
Bug Fix: Fix IE11 weekday bug #255, #300
Feature: Add capability to set fixedHeight #252
Feature: Add capability to override weekStartsOn setting #334
Feature: Add capability to set weekdayDisplayFormat and dayDisplayFormat (For being able to use different versions of date-fns) #299, #326
Feature: Add capability to set startDatePlaceholder and endDatePlaceholder (instead of Early and Continuous) #274, #292
Feature: Merged PR: Added editable DateInput components to Calendar by Vladimir Spasic #279
Feature: Merged PR: Use a dedicated component to render input ranges, show
-as a placeholder by Vladimir Spasic #278