Skip to content
This repository was archived by the owner on May 19, 2025. It is now read-only.

Conversation

@onurkerimov
Copy link
Contributor

@onurkerimov onurkerimov commented Jan 13, 2020

WIP
Demo Site

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description

  • React 16 migration and removal of deprecated methods, refactoring #331

  • Migrate date-fns into new version (2.8.1) #315

  • date-fns is now loaded as a peerDependency #294

  • Pass newly added locales directly from date-fns #245

  • Migrate all devDependencies into new versions

  • Github pages uses react-styleguidist for examples

  • Remove Webpack configuration file move completely to react-styleguidist

  • Modify Babel configuration to stay up to date

  • Remove deprecated vscode settings

  • Add Prettier-Eslint integration

  • Bug Fix: Fix IE11 weekday bug #255, #300

  • Feature: Add capability to set fixedHeight #252

  • Feature: Add capability to override weekStartsOn setting #334

  • Feature: Add capability to set weekdayDisplayFormat and dayDisplayFormat (For being able to use different versions of date-fns) #299, #326

  • Feature: Add capability to set startDatePlaceholder and endDatePlaceholder (instead of Early and Continuous) #274, #292

  • Feature: Merged PR: Added editable DateInput components to Calendar by Vladimir Spasic #279

  • Feature: Merged PR: Use a dedicated component to render input ranges, show - as a placeholder by Vladimir Spasic #278

@iuliux
Copy link

iuliux commented Jan 31, 2020

Great PR 🙏. Any timeline on merging it?

@balazsorban44
Copy link

balazsorban44 commented Feb 8, 2020

It would be great! 🎉

Amazing work @onurkerimov! I did not dare to update this package and date-fns in ages, I even had to create a patch and used that in my package.json instead.

Until this is merged, I am doing "react-date-range": "onurkerimov/react-date-range#master" (or maybe you can publish on npm @onurkerimov/react-date-range, if this PR does not get any response. Right now I have to manually run npm install;npm build by cd-ing to node_modules/react-date-range, since the dist folder is not on GitHub ) and finally "date-fns": "^2.9.0" ! You rock! 🤘

(I see this one resolves my own PR #245! 😃)

@rmkanda
Copy link

rmkanda commented Feb 11, 2020

@mkg0 @burakcan @mortargrind @keremciu @mefallit Any timeline on merging it?

Thanks in advance!!!

@rmkanda
Copy link

rmkanda commented Feb 14, 2020

@burakcan Do you have access to merge the PR?

@burakcan
Copy link
Collaborator

@rmkanda I have but I think it's better to leave that to @onurkerimov

@onurkerimov
Copy link
Contributor Author

Today we are going to merge this.
I want to thank all the contributors on this. @mkg0 @burakcan @mortargrind @keremciu @mefallit Also thanks to @vladaspasic for developing DateInput and InputRangeField components. Also thanks to @jeffyyyy for fixing IE11 bug.

@onurkerimov onurkerimov merged commit 0286988 into hypeserver:master Feb 19, 2020
@balazsorban44
Copy link

balazsorban44 commented Feb 20, 2020

@onurkerimov It's an awesome upgrade, but I have two things on my mind.

First, you mention in the CHANGELOG, that there is a breaking change. It would probably make sense then, to jump to version 2.0 to indicate people, that this is something they have to accommodate for.

Secondly, I see the package has not been published to npm as of yet.

Given the version number could be improved, it may be a good thing. I suggest you bump to 2, and THEN publish to npm as latest.

Again, AMAZING work! 🎉

UPDATE:

The format is based on Keep a Changelog and this project adheres to Semantic Versioning.

Given this, 1.1.0 is just a plain mistake!

UPDATE 2:

I may have moved on this too fast... I see the "latest" until now was 0.x.x, so technically 1.1.0 was correct, but why the x.1.x change, if there was never a 1.0.0?

@burakcan
Copy link
Collaborator

Maybe we can tag this as 1.0.0? 1.1.0 feels a bit random given there was never a 1.0.0 - unless you had internal releases. (I left the company long ago so I'm not familiar with the latest situation)

@onurkerimov added you to the npm package so you can publish a new version.

As a personal note; thanks to everyone who spent time working on this or used the library. react-date-range was my onboarding project when I first joined Adphorus :) It's exciting to see how this project grew to be what it is today.

@onurkerimov onurkerimov mentioned this pull request Feb 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants