Ballot question follow-up fixes#49
Merged
LexaMichaelides merged 4 commits intofeat/ballot-questionsfrom Apr 10, 2026
Merged
Conversation
44cdaf2 to
e596369
Compare
7c6ba47 to
47f13cb
Compare
44cdaf2 to
23a5ce5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes changes for the ballot-question demo follow-up fixes and includes the additional cleanup needed to make the BQ perspective/testimony-count behavior and BQ testimony display consistent with existing bill patterns.
Changes
Remove all BQ perspectives from the Browse Testimony page
ballotQuestionIdfrom the Typesense testimony index.Fix the way ballot questions display on Followed Content so that it shows the question number and title
Perspective count does not automatically increase after submitting
testimonyCount,endorseCount,neutralCount, andopposeCountto ballot-question documents.Remove duplicated copy “share your perspective” on the button and in the component text in the Your Perspective component
Committee hearing should open in new tab, and link format should reflect that (diagonal arrow)
On BQ Perspectives tab, retain the small text saying “review testimony on the related bill” and remove the larger callout that says “submit”
Viewing “BQ testimony” on its own page shows the title of the bill but the side panel shows ballot question detail; it should show the title of the BQ
Include Ballot Questions in the Newsfeed updates
Tests
nvm use 20.19.0 && corepack yarn check-typesnvm use 20.19.0 && corepack yarn jest components/NewsfeedCard/NewsfeedCard.test.tsx components/testimony/TestimonyDetailPage/BillTitle.test.tsx components/testimony/TestimonyDetailPage/PolicyActions.test.tsx components/ballotquestions/BallotQuestionDetails.test.tsx --runInBandnvm use 20.19.0 && cd functions && corepack yarn jest src/testimony/updateTestimonyCounts.test.ts src/notifications/populateBallotQuestionNotificationEvents.test.ts src/notifications/deliverNotifications.test.ts --runInBand