Remove dead collectionGroup fallback queries for BQ counts#52
Merged
tripledoublev merged 2 commits intofeat/ballot-questionsfrom Apr 15, 2026
Merged
Conversation
Counts are now stored on BallotQuestion docs with defaults of 0, so the hasStored/getStored helpers and live query fallbacks are unreachable. Read counts directly from the doc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BallotQuestiondocs now storetestimonyCount,endorseCount,neutralCount,opposeCountwith defaults of0collectionGroupfallback query functions (getBallotQuestionCounts,getBallotQuestionTestimonySummary) and theirhasStored*/getStored*helpers — these were always bypassed once counts were stored on the docBallotQuestiondoc in bothpages/ballotQuestions/index.tsxandpages/ballotQuestions/[id].tsx?? 0guards sinceapi.tsdoes a raw Firestore cast without running the runtype defaultsNote for reviewer
I ran the backfill scripts needed to run on dev (and prod when shipping) in this order:
backfillTestimonyBallotQuestionIdmust run first so that legacy testimony docs haveballotQuestionIdindexed before the count backfill reads them.Test plan
BallotQuestionDetails,BrowseBallotQuestions/ballotQuestionsrenders without serialization errors/ballotQuestions/[id]shows correct counts after backfill is run