Improve contrast ratio in annotation textarea#6966
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6966 +/- ##
=======================================
Coverage 99.44% 99.44%
=======================================
Files 275 275
Lines 10906 10906
Branches 2631 2631
=======================================
Hits 10846 10846
Misses 60 60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
robertknight
left a comment
There was a problem hiding this comment.
This direction looks good to me, assuming we roll out a consistent change in our component library.
I'll wait to merge this to have the change in the shared library ready. That way we can roll both changes out at the same time. |
6190b53 to
294b6b7
Compare
294b6b7 to
bc57280
Compare
| className={classnames( | ||
| 'border rounded p-2', | ||
| 'text-color-text-light bg-grey-0', | ||
| 'placeholder:text-grey-6 bg-grey-0', |
There was a problem hiding this comment.
Inherit default text color (grey-9) and set a dark-enough placeholder color that has enough contrast with white backgrounds.
As part of #6866, and following #6866 (comment), this PR updates the text color and placeholder color in the annotation textarea to darker shades of grey:
#737373) for placeholder.#202020) for the text, via inheriting the page color, as the rest of the inputs do.This PR does not cover changing this anywhere other than the annotation textarea. I'll prepare follow-up PRs to update the defaults in the shared library and other projects.
Before:


After:

