Add function for generating asset manifests #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a `generateManifest` function that generates a JSON file mapping relative asset URLs to cache-busted paths. This was extracted from the `scripts/gulp/manifest.js` file present in several downstream projects (client, lms, h) but revised to use Node's simpler promise-based file access APIs instead of Node streams.
This was referenced Oct 21, 2021
esanzgar
approved these changes
Oct 21, 2021
Comment on lines
+3
to
+5
| import * as path from 'path'; | ||
|
|
||
| import glob from 'glob'; |
Contributor
There was a problem hiding this comment.
Suggested change
| import * as path from 'path'; | |
| import glob from 'glob'; | |
| import glob from 'glob'; | |
| import * as path from 'path'; |
Contributor
Author
There was a problem hiding this comment.
The convention for imports in scripts that run in Node is:
// Node dependencies
// Third-party dependencies
// Local dependencies
This is similar to how Python lists standard library imports, followed by third-party imports, followed by vendor imports. Here path is a Node dep and glob is a third-party dependency.
Contributor
There was a problem hiding this comment.
Thanks for the clarification!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
generateManifestfunction that generates a JSON file mappingrelative asset URLs to cache-busted paths. This was extracted from the
scripts/gulp/manifest.jsfile present in several downstream projects(client, lms, h) but revised to use Node's simpler promise-based file
access APIs instead of Node streams.