Vouch req: net gain of two lines in CMakeLists.txt (maybe not so minor?)

[ilovemikael]

Repos I am interested in contributing to

hyprland

What I want to contribute right now

Whenever I compile hyprland, I see a whole lotta this:

[71/975] Building CXX object hyprctl/CMakeFiles/hyprctl.dir/hw-protocols/hyprpaper_core-client.cpp.o
warning: unknown warning option '-Wno-clobbered' [-Wunknown-warning-option]
1 warning generated.
[72/975] Building CXX object hyprpm/CMakeFiles/hyprpm.dir/src/core/HyprlandSocket.cpp.o
warning: unknown warning option '-Wno-clobbered' [-Wunknown-warning-option]
1 warning generated.
[73/975] Building CXX object hyprpm/CMakeFiles/hyprpm.dir/src/progress/CProgressBar.cpp.o
warning: unknown warning option '-Wno-clobbered' [-Wunknown-warning-option]

This is because I use clang, and this warning flag seems (I'm not knowledgeable on compilers besides those two (such as icc, for instance), so I can't say for sure ;p) to be exclusive to gcc; git blame reveals that this commit introduced the flag, stating the build failed otherwise.

I compiled with gcc without Wno-clobbered, and there wasn't even a warning, much less any errors; perhaps this flag is no longer needed at all? I wrote this snippet (before testing compilation) to conditionally enable the flag only if the user uses gcc (and conversely removed the flag from the list of default compile options). It's probably utterly unnecessary, but I spent the 5 seconds typing it out so I might as well put it here for shits and giggles. Cheers <3 !

if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
  add_compile_options(-Wno-clobbered)
endif()

Why the above bug / feature specifically?

My console being flooded with warnings of unknown warnings every time I compile hypr irritates me; clang is pretty popular (afaik), so I doubt I'm the only person peeved by the portendings.

I acknowledge that:

• I have read the AI Usage Policy and agree to follow it.

• I have read the Code of Conduct and agree to follow it.

• I wrote this request with my own hands, my own keyboard, and in my own words.

[vaxerski]

welcome aboard!