killactive/closewindow, active closes the whole app

[bczhc]

One application can spawn multiple (sub)windows. When I do killactive/closewindow, active on one window, it closes the whole app.

This affects on some applications. Three examples are listed below from my experience:

Jetbrains IDEs: When I opened multiple projects, killactive on one project window causes the whole IDE to exit immediately.

Tencent LinuxQQ: Closing the main window makes the whole app crash (qq-crash.tar.gz if this is useful), plus the tray icon disappears (because of the crash). However if you close the window via QQ's top-right "X" button, it won't happen. The tray icon will leave still, and you can click it to call the QQ main window back to show again.

Steam: After closing the window using killactive, the tray icon remains. However Steam will relaunch again and the window will show up again, after a little while (maybe due to restart-on-crash mechanism of Steam i guess).

---

This java swing application demonstrates the issue:

import java.awt.BorderLayout;
import java.awt.Dimension;

import javax.swing.JButton;
import javax.swing.JFrame;
import javax.swing.JTextPane;
import javax.swing.SwingUtilities;

public class HyprlandSwingRepro {
    public static void main(String[] args) {
        SwingUtilities.invokeLater(() -> {
            makeWin("Window 1", 100);
            makeWin("Window 2", 500);
        });
    }

    private static void makeWin(String title, int x) {
        JFrame f = new JFrame(title);
        f.setDefaultCloseOperation(JFrame.DISPOSE_ON_CLOSE);

        JButton btn = new JButton("Close " + title);
        btn.addActionListener(e -> f.setVisible(false));

        f.add(btn, BorderLayout.CENTER);
        f.setPreferredSize(new Dimension(300, 200));
        f.pack();
        f.setLocation(x, 200);
        f.setVisible(true);
    }
}

To run it:

javac HyprlandSwingRepro.java
java HyprlandSwingRepro

This Java app starts two windows. Close one window (via killactive not via the GUI button. GUI buttons act as expected.), two windows all disappear and program exits. When you close Window 1 first, it's 100% reproducible. When you close Window 2 first, the issue happens about 3/10. Interestingly if wf-recorder is running, the former one is 100% reproducible but the latter one is very hard to reproduce (1/35 e.g.).

Ran a bisect and this is introduced by #13156. Could you have a look please? @gulafaran

[bczhc]

Just tested and confirmed this got fixed by a20142b. cc and thx @vaxerski! Closing ~