Main branch build breaks

[logrusx]

git/hyprland/hyprctl/src/hyprpaper/Hyprpaper.cpp: In function ‘std::expected<void, std::__cxx11::basic_string<char> > doListActive()’:
git/hyprland/hyprctl/src/hyprpaper/Hyprpaper.cpp:179:30: error: ‘CCHyprpaperStatusObject’ was not declared in this scope; did you mean ‘CCHyprpaperWallpaperObject’?
  179 |     auto status = makeShared<CCHyprpaperStatusObject>(manager->sendGetStatusObject());
      |                              ^~~~~~~~~~~~~~~~~~~~~~~
      |                              CCHyprpaperWallpaperObject
git/hyprland/hyprctl/src/hyprpaper/Hyprpaper.cpp:179:64: error: ‘class CCHyprpaperCoreManagerObject’ has no member named ‘sendGetStatusObject’; did you mean ‘sendGetWallpaperObject’?
  179 |     auto status = makeShared<CCHyprpaperStatusObject>(manager->sendGetStatusObject());
      |                                                                ^~~~~~~~~~~~~~~~~~~
      |                                                                sendGetWallpaperObject
git/hyprland/hyprctl/src/hyprpaper/Hyprpaper.cpp:183:13: error: ‘class Hyprwire::IClientSocket’ has no member named ‘roundtrip’
  183 |     socket->roundtrip();
      |             ^~~~~~~~~

[ItsOhen]

You have to clear out the old .cpp and .hpp files from hyprctl/hw-protocols
Why we generate .cpp and .hpp files in the source dir instead of the build dir is beyond me. But hey, here we are.

[logrusx]

Thank you!

git status showed nothing. Then I grepped for the missing objects and grep reported nothing. Then for similarly named objects and grep reported a file containing CCHyprpaperCoreManagementObject. I decided to take a look at it and fired a Neovim instance. I was surprised it didn't show in oil-nvim file browser. I suspected files were not committed. But then I realized grep was reporting files I didn't see in the file browser. I checked .gitignore and found the following lines:

hyprctl/hw-protocols/*.c*
hyprctl/hw-protocols/*.h*

That's why git status shows nothing.

And yes, the build files need serious reconsideration.

[logrusx]

But then it breaks with this:

git/hyprland/hyprctl/src/hyprpaper/Hyprpaper.cpp: In function ‘std::expected<void, std::__cxx11::basic_string<char> > doListActive()’:
git/hyprland/hyprctl/src/hyprpaper/Hyprpaper.cpp:183:13: error: ‘class Hyprwire::IClientSocket’ has no member named ‘roundtrip’
  183 |     socket->roundtrip();
      |             ^~~~~~~~~
At global scope:
cc1plus: note: unrecognized command-line option ‘-Wno-gnu-zero-variadic-macro-arguments’ may have been intended to silence earlier diagnostics
gmake[2]: *** [hyprctl/CMakeFiles/hyprctl.dir/build.make:89: hyprctl/CMakeFiles/hyprctl.dir/src/hyprpaper/Hyprpaper.cpp.o] Error 1
gmake[2]: *** Waiting for unfinished jobs....
git/hyprland/start/src/core/Instance.cpp: In lambda function:
git/hyprland/start/src/core/Instance.cpp:84:14: warning: ignoring return value of ‘ssize_t write(int, const void*, size_t)’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
   84 |         write(m_wakeupWrite.get(), "vax", 3);
      |         ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
git/hyprland/start/src/core/Instance.cpp: In member function ‘void CHyprlandInstance::clearFd(const Hyprutils::OS::CFileDescriptor&)’:
git/hyprland/start/src/core/Instance.cpp:100:9: warning: ignoring return value of ‘ssize_t read(int, void*, size_t)’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  100 |     read(fd.get(), buf.data(), 1023);
      |     ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
git/hyprland/start/src/core/Instance.cpp: In member function ‘bool CHyprlandInstance::run(bool)’:
git/hyprland/start/src/core/Instance.cpp:135:9: warning: ignoring return value of ‘int pipe(int*)’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  135 |     pipe(pipefds);
      |     ~~~~^~~~~~~~~
git/hyprland/start/src/core/Instance.cpp:140:9: warning: ignoring return value of ‘int pipe(int*)’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  140 |     pipe(pipefds);
      |     ~~~~^~~~~~~~~

Is this due to the newer version of Hyprwire I haven't installed?

[ItsOhen]

No, that looks like you forgot to regen the files.
rm -R build && make release should fix it right up.

[logrusx]

‘class Hyprwire::IClientSocket’ has no member named ‘roundtrip’

It must be Hyprwire related. Actually I'm still at 0.2.1 and this particular change made it in 0.3.0. I'm not sure if that version breaks ABI and I think that's why I didn't bump it right away but left it for the next Hyprland release. I'm marking your first replay as an answer.

[kralos]

FYI you can delete all files marked as ignored by .gitignore - https://gitlab.com/kralos/hyprbuntu/-/blob/main/setup-hyprbuntu.sh?ref_type=heads#L92

git clean -fX

or to also delete untracked files and folders that are not .gitignored and nested git directories too:

git clean -ffdx

This is safer than just rm -rf build

[logrusx]

FYI you can delete all files marked as ignored by .gitignore

Thanks for sharing. Git is one of those things you always have something more to learn about.

git clean -ffdx

This is safer than just rm -rf build

It's not safer, it just does a better job. Which shouldn't have been necessary if the build systems was sane first place.