Toggle maximize doesn't unmaximize window on scrolling layout

[tomkoid]

The toggle action for maximized windows works as expected on the dwindle layout, but it's not working on the scrolling layout. While the window maximizes correctly, toggling it a second time doesn't restore it to its original size.

Am I hitting a bug here or am I just missing something?

hl.bind(mainMod .. " + F", hl.dsp.window.fullscreen({ mode = "maximized", action = "toggle" }))

[vaxerski]

correct. Not implemented. Maximize is a shorthand for expel + width 1 atm

[preArcMed821]

@vaxerski Thanks for the clarification, out of interest, are there plans (at some point) to make this work in a better way. Appreciate all your work!

[chachi-touchpulse]

I used to have the following bind:

bind = SUPER, F, fullscreen, 1

and using scrolling layout. It maximized (and unmaximized) correctly.
Was this feature just removed? Is it planned to be (re)implemented?

[shinnkka]

Maybe the behavior could be changed like this: if the width is already 1, then restore column_width; otherwise, set the width to 1.

[jr64]

It would be really awesome if this feature could be added back in the future, it's a pretty major disruption of my usual workflow.

I often have a bunch of smaller terminal windows in a single column and use fullscreen with mode = "maximize" to zoom into one of them whenever needed (e.g. when reading long lines).

With this behavior change there seems to be no way to automatically move the window back to the same vertical position it was in before it was maximized. I have to manually move the window back into the column and then to the desired position.

[EvilBoi123]

im sure this'll be added soon, but what i noticed differences between 0.54 and 0.55, is that in 0.54, it can return back to previous state, but we can't access the "pushed windows to the side" without unmaximize it back, but in 0.55, we CAN access it even if it maximize, i think vaxery forgot to implement it to be able to return it to back to original state with this new logic.

[Chachi04]

I found a fairly simple and decent workaround until they fix it internally.

hl.config({
	scrolling = {
		focus_fit_method = 1,
		explicit_column_widths = "0.5,1",
	},
})

bind("SUPER + F", function()
	hl.dispatch(hl.dsp.layout("colresize +conf"))
	hl.dispatch(hl.dsp.layout("focus r"))
	hl.dispatch(hl.dsp.layout("focus l"))
end, { description = "Toggle active window to maximized (scrolling)" })

[NeoPlayer13]

Pretty good workaround! Just fix the misplaced parenthesis after "SUPER + F"

[preArcMed821]

Thanks all for the suggestions. Came across this issue myself under scrolling. I see two issues:

1. As other said, maximizing with toggle will not reverse to the original size
2. If you have two apps side-by-side 50% each, and then if you maximize the right hand side window. It maximizes but it grows large off the screen, you then need to focus to the right so the whole window can be seen.

Thanks all, trying to make the move from niri and this is the final piece of my workflow I've not been able to replicate.

[preArcMed821]

I have another (not very robust) temporary workaround, it combines some of @Chachi04 work:

local had_left_neighbor = false

hl.bind(mainMod .. " + F", function()
  local w = hl.get_active_window()
  if w == nil then return end

  local win_w = w.width or w.w or (w.size and w.size.x) or (w.size and w.size[1])
  local mon = w.monitor
  local mon_w = mon and (mon.width or mon.w or (mon.size and mon.size.x))
  if not win_w or not mon_w then return end

  local ratio = win_w / mon_w

  if ratio < 0.85 then
    -- About to maximize: check if there's a column to the left by trying
    -- to focus left and seeing if the focused window changes.
    local before = w
    hl.dispatch(hl.dsp.layout("focus l"))
    local after = hl.get_active_window()
    had_left_neighbor = (after ~= nil and after ~= before)
    -- Restore focus to original column before maximizing.
    if had_left_neighbor then
      hl.dispatch(hl.dsp.layout("focus r"))
    end
    hl.dispatch(hl.dsp.layout("colresize 1.0"))
  else
    -- Shrinking: only do the nudge if we had a left neighbor going in.
    hl.dispatch(hl.dsp.layout("colresize 0.5"))
    if had_left_neighbor then
      hl.dispatch(hl.dsp.layout("focus l"))
      hl.dispatch(hl.dsp.layout("focus r"))
    end
    had_left_neighbor = false
  end
end)

It compares the size of the active window to the active monitor. If the window size is less that 85% of the monitor, it will resize the column to 1.0 making it "maximized". Run the bind again and it will make the column 0.5 (half).

It also checks which side of the screen it is so it always returns the window positions correctly

It doesn't remember the previous size sadly but it's sufficient for me until it is fixed 🤞

[preArcMed821]

This is not perfect, sometimes it won't return the original pair of apps when you shrink it