Hyprland leaks file descriptiors into everything it runs

[kressb-gitlab]

On my system (hyprland 0.55.2), hyprland leaks file descriptors into everything it launches. For instance, my shell in addition to having the expected 0, 1, 2, and 255, also has 4, 5, 6, 7, and 13.

4-7 are pipes opened by start/src/core/Instance.cpp in CHyprlandInstance::run()
13 is an inotify watch on hyperland.lua opened by src/config/shared/inotify/ConfigWatcher.cpp in CConfigWatcher::CConfigWatcher()

These are passed from Hyperland into my bar, into my terminal and finally into my shell. The same 5 fds are open in almost every user process on my system. These need to be marked O_CLOEXEC or be closed by the exec code.

[vaxerski]

oops.

[vaxerski]

can you check if I got them all in #14870 ?

[kressb-gitlab]

The ones in Instance.cpp being CL_ONEXEC are problematic. if I read this correctly this is where start-hyprland spawns Hyprland, and I think Hyprland actually sort of expects to inherit these? So Hyprland would have to set the flags, not start-hyprland.

Assuming I am reading that right.

[vaxerski]

No, I CLOEXEC'd the three hyprland doesn't inherit. The last one is inherited and Hyprland will CLOEXEC it on its own.