Hyprutils broke several hypr packages

[ctilley83]

I compile all hyprland repos manually. I'm encountering Hyprutils pointer errors while trying to compile several hypr repos including hyprland. I''m assuming Hyprutils has been refactored and those changes haven't been pushed to repos that require memory management features of hyprutils? Should I sit tight?

Hyprland:
cc1plus: note: unrecognized command-line option ‘-Wno-gnu-zero-variadic-macro-arguments’ may have been intended to silence earlier diagnostics
At global scope:
cc1plus: note: unrecognized command-line option ‘-Wno-gnu-zero-variadic-macro-arguments’ may have been intended to silence earlier diagnostics
make[4]: *** [CMakeFiles/hyprland_lib.dir/build.make:713: CMakeFiles/hyprland_lib.dir/src/config/lua/bindings/LuaBindingsDispatchers.cpp.o] Error 1
make[4]: *** Waiting for unfinished jobs....
make[4]: *** [CMakeFiles/hyprland_lib.dir/build.make:601: CMakeFiles/hyprland_lib.dir/src/config/legacy/DispatcherTranslator.cpp.o] Error 1
In file included from /home/SourceApps/hyprland-git/Hyprland/src/config/legacy/../../render/Renderer.hpp:25:
/home/ey/SourceApps/hyprland-git/Hyprland/src/config/legacy/../../render/../desktop/view/LayerSurface.hpp: In function ‘bool Desktop::View::valid(PHLLS)’:
/home/SourceApps/hyprland-git/Hyprland/src/config/legacy/../../render/../desktop/view/LayerSurface.hpp:91:16: error: cannot convert ‘PHLLS’ {aka ‘Hyprutils::Memory::CSharedPointerDesktop::View::CLayerSurface’} to ‘bool’ in return
91 | return l;
| ^
| |
| PHLLS {aka Hyprutils::Memory::CSharedPointerDesktop::View::CLayerSurface}
/usr/include/hyprutils/memory/SharedPtr.hpp:109:22: note: explicit conversion function was not considered
109 | explicit operator bool() const {
| ^~~~~~~~
/home/SourceApps/hyprland-git/Hyprland/src/config/legacy/../../render/../desktop/view/LayerSurface.hpp: In function ‘bool Desktop::View::valid(PHLLSREF)’:
/home/SourceApps/hyprland-git/Hyprland/src/config/legacy/../../render/../desktop/view/LayerSurface.hpp:95:16: error: cannot convert ‘PHLLSREF’ {aka ‘Hyprutils::Memory::CWeakPointerDesktop::View::CLayerSurface’} to ‘bool’ in return
95 | return l;
| ^
| |
| PHLLSREF {aka Hyprutils::Memory::CWeakPointerDesktop::View::CLayerSurface}
/usr/include/hyprutils/memory/WeakPtr.hpp:174:22: note: explicit conversion function was not considered
174 | explicit operator bool() const {

Aquamarine:

/home//SourceApps/hyprland-git/aquamarine/src/backend/drm/DRM.cpp: In member function ‘bool Aquamarine::CDRMBackend::shouldBlit()’:
/home//SourceApps/hyprland-git/aquamarine/src/backend/drm/DRM.cpp:648:12: error: cannot convert ‘Hyprutils::Memory::CWeakPointerAquamarine::CDRMBackend’ to ‘bool’ in return
648 | return primary;
| ^~~~~~~
| |
| Hyprutils::Memory::CWeakPointerAquamarine::CDRMBackend
In file included from /usr/include/hyprutils/signal/Signal.hpp:11,
from /home/SourceApps/hyprland-git/aquamarine/./include/aquamarine/output/Output.hpp:5,
from /home/SourceApps/hyprland-git/aquamarine/src/backend/drm/DRM.cpp:1:
/usr/include/hyprutils/memory/WeakPtr.hpp:174:22: note: explicit conversion function was not considered
174 | explicit operator bool() const {
| ^~~~~~~~
make[2]: *** [CMakeFiles/aquamarine.dir/build.make:240: CMakeFiles/aquamarine.dir/src/backend/drm/DRM.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:1018: CMakeFiles/aquamarine.dir/all] Error 2
make: *** [Makefile:146: all] Error 2

[tekstryder]

Yah busted. hyprgraphics built successfully against hyprwm/hyprutils@9d8bf6e at least.

Not so much with AQ. So how did @NotPppp1116 and @vaxerski build this pig?

-- Build files have been written to: /srv/build/aquamarine/src/build
[0/2] Re-checking globbed directories...
[17/35] Building CXX object CMakeFiles/attachments.dir/tests/Attachments.cpp.o
FAILED: [code=1] CMakeFiles/attachments.dir/tests/Attachments.cpp.o 
/usr/sbin/c++ -DAQUAMARINE_VERSION=\"0.12.1\" -I/srv/build/aquamarine/src/aquamarine/./include -isystem /usr/include/pixman-1 -isystem /usr/include/libdrm -march=native -O3 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection         -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wp,-D_GLIBCXX_ASSERTIONS -flto=auto -std=gnu++23 -Wall -Wextra -Wno-unused-parameter -Wno-unused-value -Wno-missing-field-initializers -Wpedantic -O3 -MD -MT CMakeFiles/attachments.dir/tests/Attachments.cpp.o -MF CMakeFiles/attachments.dir/tests/Attachments.cpp.o.d -o CMakeFiles/attachments.dir/tests/Attachments.cpp.o -c /srv/build/aquamarine/src/aquamarine/tests/Attachments.cpp
In file included from /srv/build/aquamarine/src/aquamarine/tests/Attachments.cpp:4:
/srv/build/aquamarine/src/aquamarine/tests/Attachments.cpp: In function ‘int main()’:
/srv/build/aquamarine/src/aquamarine/tests/shared.hpp:16:113: error: no match for ‘operator<<’ (operand types are ‘std::basic_ostream<char>’ and ‘const Hyprutils::Memory::CSharedPointer<CFooAttachment>’)
   16 |         std::cout << Colors::RED << "Failed: " << Colors::RESET << #expr << ", expected " << val << " but got " << RESULT << "\n";                                                 \
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~ ~~~~~~
      |                                                                                                  |                 |
      |                                                                                                  |                 const Hyprutils::Memory::CSharedPointer<CFooAttachment>

EDIT: I didn't actually try building anything against hyprwm/hyprutils@9157e1c, so should not have tagged NotPppp1116 here.

[vaxerski]

fwiw all those compile errors are pretty much bugs, I just patched up the hole in hu

[tekstryder]

Gotcha. Get 'em exposed.

Built the stack against hyprwm/hyprutils@9157e1c for now.

[vaxerski]

fixed

[tekstryder]

fixed

AQ?

[tekstryder]

AQ?

Also fixed.

All good now chief. hyprlauncher crashes now cuz pango, but unrelated I think. I'll pop open an issue with stacktrace.

[tekstryder]

Hi @ctilley83, please rebuild the stack and mark this discussion as answered.

Should be all good now as of:

• hyprwm/aquamarine@6d6e238
• 5a7078d

[Haku-taku]

build failure confirmed

> env -u LC_MESSAGES make
[  4%] Building CXX object CMakeFiles/hyprlauncher.dir/src/main.cpp.o
In file included from /usr/include/hyprtoolkit/element/Text.hpp:8,
                 from /home/ollie/git/hyprlauncher/src/ui/UI.hpp:6,
                 from /home/ollie/git/hyprlauncher/src/main.cpp:1:
/usr/include/hyprgraphics/resource/resources/TextResource.hpp:7:10: fatal error: pango/pango-font.h: No such file or directory
    7 | #include <pango/pango-font.h>
      |          ^~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/hyprlauncher.dir/build.make:278: CMakeFiles/hyprlauncher.dir/src/main.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:1011: CMakeFiles/hyprlauncher.dir/all] Error 2
make: *** [Makefile:146: all] Error 2

My PR hyprwm/hyprgraphics#47 actually introduce pango to TextResource.hpp of hyprgraphics which is included by hyprtoolkit.
besides the PR above, I also submitted another one so as to fix the include search dir issues during compilation for packages that use hyprgraphics.

I tried add hyprgraphics to CMakeLists and then build hyprlaucher on Haku-taku/hyprgraphics@3f4280d and it passed.

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 1c56329..57b948f 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -27,6 +27,7 @@ pkg_check_modules(
   pixman-1
   libdrm
   hyprutils>=0.10.2
+  hyprgraphics
   hyprwire
   icu-uc
   hyprlang

[Haku-taku]

Another simple solution is to replace PANGO_WEIGHT_NORMAL with it actual value 400

[Haku-taku]

oh, since hyprgraphics is not directly used by hyprlauncher, May add Requires section to hyprtoolkit's pkgconfig be more practical?

And shall we complete hypr packages' pkg-config to avoid similiar build issues?

[vp1981]

Also, there are problems with hyprlock and xdg-desktop-portal-hyprland.

And pango-related stuff affects hyprshutdown, hyprpwcenter, hyprlauncher and hyprpaper.

[tekstryder]

Thanks for your replies @Haku-taku.

besides the PR above, I also submitted another one so as to fix the include search dir issues during compilation for packages that use hyprgraphics.

I'd missed that unmerged, but approved, PR last night looking into this.

oh, since hyprgraphics is not directly used by hyprlauncher, May add Requires section to hyprtoolkit's pkgconfig be more practical?
And shall we complete hypr packages' pkg-config to avoid similiar build issues?

Almost certainly. Need @vaxerski to sort this out.

[tekstryder]

Also, there are problems with hyprlock and xdg-desktop-portal-hyprland.

Yeah those will have to wait till he wakes up. The fixes are trivial.

@vp1981 that's already noted upthread.

The thread is long (click to see previous), and there are two issues discussed:

Issue 1: hyprutils commit flushed out broken stuff in various components throughout the ecosystem:

EDIT: This is fully fixed now

Breaking commit:

• memory: fix implicit comparison of unrelated types hyprutils#114

Bug report:

• Hyprutils broke several hypr packages #15201

Fixes so far:

hyprland fixed: 5a7078d
aquamarine fixed: hyprwm/aquamarine@6d6e238
xdg-desktop-portal-hyprland fixed: hyprwm/xdg-desktop-portal-hyprland#410
hyprlock fixed: hyprwm/hyprlock#1040

Issue 2: hyprgraphics commit broke various components throughout the ecosystem:

EDIT: This is fully fixed now as of commit hyprwm/hyprtoolkit@dc42c8d.

Breaking commit:

• render: add missing weight and italic to STextResourceData hyprgraphics#47

Bug report:

• Build failure [pango-font.h] with latest hypr-stack hyprlauncher#146

Fixes so far:

• packaging: add Requires to pkgconfig for automatic make cflags hyprgraphics#48
• cmake/packaging: add auto pkg-config gen to CMakeLists hyprtoolkit#99

Additional info: hyprwm/hyprlauncher#146 (comment)

I'll edit this post as fixes land for the remaining broken components.

[tekstryder]

Vaxry has said he's busy moving, so things are kinda at a standstill here.

Thanks for proposing a path forward to get this sorted out.

[tekstryder]

Progress. hyprtoolkit PR...

• cmake/packaging: add auto pkg-config gen to CMakeLists hyprtoolkit#99

Allows for successfully building hyprlauncher.

I do not build/use any of hyprshutdown, hyprpwcenter, or hyprpaper, so others will need to test those.

Tracking comment updated.

[tekstryder]

hyprshutdown, hyprpwcenter, or hyprpaper

@vp1981 please test building these components against hyprwm/hyprtoolkit@dc42c8d.

Issue 2 should be fully solved now.

[tekstryder]

@ctilley83 please test building the full stack now and mark as answered if no build issues remain.

Issue 1 should also be fully solved now with hyprwm/hyprlock@c72fd24 and hyprwm/xdg-desktop-portal-hyprland@882ad01.

[vp1981]

@tekstryder, everything builds fine now.

[ctilley83]

All memory management build errors and pango-font import errors have been resolved on all aforementioned hypr repos. The following is a list of hypr repos my script compiles.

"hyprwayland-scanner"
"hyprland-protocols"
"hyprutils"
"hyprlang"
"hyprland-qt-support"
"hyprqt6engine"
"aquamarine"
"hyprgraphics"
"hyprtoolkit"
"hyprland-guiutils"
"hyprcursor"
"hyprwire"
"Hyprland"
"hyprlock"
"hyprpicker"
"hyprpaper"
"hypridle"
"xdg-desktop-portal-hyprland"
"hyprsysteminfo"
"hyprpolkitagent"
"Hyprshot"
"hyprsunset"
"hyprpwcenter"
"hyprlauncher"
"hyprshutdown"

[tekstryder]

Thorough. Nice.

Now if only hypr CI did that ;)