hyprpm does not update headers if it's just an ABI change

[VirtCode]

Hyprland version

v0.56.1

Is this a regression?

yes, regressed by #15391

What's the bug?

hyprpm doesn't update headers if it the ABI hash changes but not the actual hl commit. This means the plugin gets built against the old headers, which make the ABI string of the plugin be the old version, which doesn't match what hyprland is running.

This is an issue because e.g. arch pumped out 0.56.1-1 and 0.56.1-2 between which aq was bumped from 13 to 14, but the hash didn't change. If users now update, hyprpm doesn't update the headers as the hyprland hash stayed the same, and rebuilds the plugins against the old version with the old ABI signature. Loading them will obviously fail.

Honestly I would've taken some time to fix it but the hyprpm sources are the biggest spaghett and I don't really have time right now (got a thesis and exams to worry about). If I were to fix it I'd change the implementation entirely and treat the ABI hash exactly the same as GIT_COMMIT_HASH and not build it in __hyprland_api_get_client_hash() (but at build time). In hyprpm we'd then just use that hash instead. I really don't know why it's done like it is currently done (the ABI only being tracked in global state) maybe I didn't think this through enough.

Reproduction steps

You can try to simulate an ABI break by changing the headers and global state:

1. Run hyprpm update with at least one plugin installed to have the newest headers.
2. Simulate an ABI break by making the changing the ABI and global state hash. E.g. with:

sudo sed -i "s/aq_0.14/aq_0.13/g" /var/cache/hyprpm/vaxry/state.toml
sudo sed -i "s/AQUAMARINE_VERSION \"0.14.0\"/AQUAMARINE_VERSION \"0.13.0\"/g" /var/cache/hyprpm/vaxry/headersRoot/include/hyprland/src/version.h

3. Run hyprpm update. See how it doesn't update the headers, but rebuilds the plugin. The __hyprland_api_get_client_hash() now returns the signature of the outdated headers and the plugin doesn't load.

Related

• Plugin builds but does not load after hyprpm update VirtCode/hypr-dynamic-cursors#159
• doesn't compile on 0.55.4 latest Hyprland release through hyprpm VirtCode/hypr-dynamic-cursors#155 (comment) (title is misleading, is more of a meta-issue at this point)

I acknowledge that:

• I have searched all (open and closed) discussions and issues and my problem is not there.
• I have read the Code of Conduct and agree to follow it.
• I wrote this request with my own hands, my own keyboard, and in my own words.

[AsfhtgkDavid]

is there anything workarounds?

[AsfhtgkDavid]

hyprpm update -f helped

[VirtCode]

@vaxerski

[vaxerski]

MRs welcome

[VirtCode]

sure I can have a try in a month or so when I have a bit of free time again
(I kinda meant to promote this to an issue with the ping, cause 5 upvotes, but sure haha)

[vaxerski]

oh, didn't notice. Sure.

[vaxerski]

#15757