Missing YUV-to-RGB conversion when rendering YUV DMA-BUF textures

[adamant-pwn]

Hyprland version

v0.56.2

Is this a regression?

Unknown

What's the bug?

All videos in Firefox gain red/orange tint on AMD GPU when using gfx.color_management.hdr = true. This happens in both SDR and HDR monitor modes. This was reported in #16097, but was closed without substantial consideration.

Reproduction steps

1. Set gfx.color_management.hdr = true in Firefox 156.0.1 running natively on Wayland
2. Open any video

Attachments

Specific issue, according to AI, appears to be the commented-out YUV texture-selection branch from #12879:

Hyprland/src/render/gl/GLTexture.cpp

Lines 77 to 85 in efb5099

	// #TODO external only formats should be external as well.
	// also needs a separate color shader.
	/*if (NFormatUtils::isFormatYUV(attrs.format)) {
	m_target = GL_TEXTURE_EXTERNAL_OES;
	m_type = TEXTURE_EXTERNAL;
	} else {*/
	m_target = GL_TEXTURE_2D;
	m_type = isDrmFormatOpaque(attrs.format) ? TEXTURE_RGBX : TEXTURE_RGBA;
	//}

Selecting external sampling here for NV12/P010 removes the red tint, but is insufficient: the external shader bypasses the normal color management stage, so HDR brightness and colors can still be wrong.

I acknowledge that:

• I have searched all (open and closed) discussions and issues and my problem is not there.

• I have read the Code of Conduct and agree to follow it.

• I wrote this request with my own hands, my own keyboard, and in my own words.

[finalfantasian]

Yeah can confirm that this happens to me too. Unfortunately can't find a solution. Any fixes?

[vaxerski]

are we deadass we are using yuv in 2026

[adamant-pwn]

Firefox does: its Wayland HDR implementation explicitly requires NV12/P010 YUV support from the compositor.

-- Sent from my ChatGPT

[Honkazel]

DMA-BUF YUV isn't supported by hyprland. YUV and it's variatives, such as aforementioned NV12/P010, is used in many, if not all videos. Captain obvious, I know. Also MPV in dmabuf-wayland backend do use it for a long time
-- Not sent by any AI, it's just a thing since the time you wrote DMABUF implementation to go away from wlroots implementation

[vaxerski]

ugh.

[vaxerski]

#16570