Skip to content

Adds support for date literals #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 15, 2021
Merged

Adds support for date literals #174

merged 10 commits into from
Jun 15, 2021

Conversation

@klauck
Copy link
Contributor

@klauck klauck commented Jun 11, 2021 •
edited by mweisgut
Loading

Add support for date literals as requested by issue #173 (qgen query rejected by hsql's DATE handling)

Fix #173

@klauck klauck requested a review from mweisgut June 11, 2021 12:33
@klauck klauck mentioned this pull request Jun 11, 2021
Closed
@mweisgut
Copy link
Contributor

mweisgut commented Jun 14, 2021 •
edited
Loading

@klauck could you please review my changes? A passed date string, e.g. 1960-09-31, is still matched as a STRING with the current pattern matching rules defined in flex_lexer.l. I added a simple string format check in the date_literal rule and some tests.

klauck
klauck commented Jun 14, 2021
View reviewed changes
@mweisgut mweisgut merged commit 4248c76 into master Jun 15, 2021
@klauck klauck deleted the klauck/feature_date_literal branch July 8, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mweisgut mweisgut mweisgut approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

qgen query rejected by hsql's DATE handling

3 participants

@klauck @mweisgut