Enable importing of container name-only images and user-rules via sdscli#106
Merged
mcayanan merged 2 commits intohysds:developfrom Mar 8, 2024
Merged
Enable importing of container name-only images and user-rules via sdscli#106mcayanan merged 2 commits intohysds:developfrom
mcayanan merged 2 commits intohysds:developfrom
Conversation
…mporting of user rules
Contributor
|
This PR looks straight forward enough but would like a 2nd pair of eyes on this to make sure we're not impacting anything with what core is doing now. I couldn't see any issues. Looks like the changes allow more flexibility to not expect certain fields when importing a package. |
Contributor
|
LGTM, but lets get another pair of eyes |
Contributor
|
@joshgarde Could you please bump up the version in https://github.com/sdskit/sdscli/blob/59874cf04efa6ac016629925c12a0196a612d2a2/sdscli/__init__.py#L6 to |
pymonger
reviewed
Mar 8, 2024
Contributor
pymonger
left a comment
pymonger
left a comment
There was a problem hiding this comment.
LGTM pending the version bump
Contributor
Author
|
Version bumped |
mcayanan
approved these changes
Mar 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://hysds-core.atlassian.net/browse/HC-517
Add support in sdscli for container specifications which do not specify a container_url and only specify a container_name. This behavior is already supported within hysds-core and only requires a tooling change to the sds pkg import command.
https://github.com/hysds/hysds/blob/944d3a89997b1aff416dc627b095a6b5e10b2242/hysds/containers/base.py#L279-L283
Additionally, add support for importing user rules from a package if part of the package.