Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Member
Author
supun-io
requested changes
Oct 13, 2025
Member
supun-io
left a comment
supun-io
left a comment
There was a problem hiding this comment.
Unlike API keys, users should be able to copy the webhook secret later.
- Do not send the key in the WebhookObject
- Add a button in the WebhookRow to copy the secret. This calls a new API endpoint which returns the secret. Then, copies to the clipboard
- Remove the modal that shows "this is the only time...."
supun-io
approved these changes
Oct 13, 2025
supun-io
added a commit
that referenced
this pull request
Oct 24, 2025
* Add secret key to backend * Fix test * Fix test * Add signature in DB and go * test fixes * minor updates * Change front to copy secret * Fix doc --------- Co-authored-by: Supun Wimalasena <supun@hyvor.com> Co-authored-by: Supun Wimalasena <44988673+supun-io@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.