Skip to content

fix: accepted and bounced state on DATACLOSE failure#426

Merged
supun-io merged 1 commit into
mainfrom
400-in-a-send-fails-at-dataclose-it-is-marked-as-both-bounced-and-accepted
May 21, 2026
Merged

fix: accepted and bounced state on DATACLOSE failure#426
supun-io merged 1 commit into
mainfrom
400-in-a-send-fails-at-dataclose-it-is-marked-as-both-bounced-and-accepted

Conversation

@Nolab0
Copy link
Copy Markdown
Member

@Nolab0 Nolab0 commented May 3, 2026

Close #400
close #362

@Nolab0 Nolab0 requested a review from supun-io May 3, 2026 07:43
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 3, 2026

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
worker/send.go 90.90% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@supun-io supun-io changed the title Fix accepted and bounced state on DATACLOSE failure fix: accepted and bounced state on DATACLOSE failure May 9, 2026
@supun-io
Copy link
Copy Markdown
Member

issue is not fixed:

image

reproduce with this (using missing+atdata):

curl -X POST https://relay.hyvor.localhost/api/console/sends      -H "Authorization: Bearer test-api-key"      -H "Content-Type: application/json"      -d '{
           "from": "test@hyvor.local.testing",
           "to": "missing+atdata@simulator.net",
           "subject": "Hello from Hyvor Relay",
           "body_text": "This is a test email sent via the API."
         }'

(make sure to upgrade simulator to the latest, 0.0.9)

Copy link
Copy Markdown
Member

@supun-io supun-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@supun-io
Copy link
Copy Markdown
Member

please ignore the previous comment - it worked perfectly

@supun-io supun-io merged commit bb665e3 into main May 21, 2026
5 checks passed
@supun-io supun-io deleted the 400-in-a-send-fails-at-dataclose-it-is-marked-as-both-bounced-and-accepted branch May 21, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In a send fails at DATACLOSE, it is marked as both bounced and accepted Invalid Partial Accepted

3 participants