feat(ui): add missing embedding model error page#1701
Conversation
Signed-off-by: Petr Kadlec <petr@puradesign.cz>
Summary of ChangesHello @kapetr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the user experience during local development by introducing a dedicated error page for missing embedding model configurations, aligning with the existing error handling for large language models. It refactors the A2A client setup for better organization and introduces a flexible error display component, ensuring users receive clear guidance when essential models are not configured. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new feature to check for missing LLM or embedding model configurations and display a user-friendly error page. It also includes a good refactoring of the A2A client creation and error handling logic into a dedicated agent-card.ts file, improving modularity and reusability. The dynamic error messages for model selection are a nice touch for user experience.
apps/agentstack-ui/src/app/(main)/run/[providerId]/model-check.tsx
Outdated
Show resolved
Hide resolved
apps/agentstack-ui/src/modules/runs/contexts/agent-run/AgentRunProvider.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Petr Kadlec <petr@puradesign.cz>
| const { error } = await ensureModelSelected(providerId); | ||
| if (error) { | ||
| return error; | ||
| } |
There was a problem hiding this comment.
It's not necessary to change it, but I personally would find it a little clearer if it returned the component, like this:
const { ErrorComponent } = await ensureModelSelected(providerId);
if (ErrorComponent) {
return <ErrorComponent />;
}
At least at first glance, it indicates that something is being rendered. What do you think?
There was a problem hiding this comment.
I like that, I was also struggling with this not being obvious.
Signed-off-by: Petr Kadlec <petr@puradesign.cz>
Summary
Check the selected models against the actual agent demands, and provide an error message for a missing embedding model configuration, analogous to the existing error for a missing main model.
Linked Issues
Closes #1673
Documentation