docs(agentstack-cli): mark admin-only and local-only commands#1813
Conversation
Summary of ChangesHello @JanPokorny, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the user experience of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request consistently adds [Admin only] and [Local only] markers to the help texts of various CLI commands, which improves clarity for users. I've noticed some inconsistencies in how the help texts are implemented across different files. While some files move the help text to the help parameter of the typer decorator and remove the now-redundant docstring (a clean approach), others just update the docstring, or a mix of both. My review comments focus on making these implementations consistent across the codebase for better maintainability. I've also pointed out a case where help text was missed for a command alias.
| @app.command("add") | ||
| async def add_provider( | ||
| capability: typing.Annotated[ | ||
| ModelCapability | None, typer.Argument(help="Which default model to change (llm/embedding)") | ||
| ] = None, | ||
| ): | ||
| """Add a new model provider. [Admin only]""" |
There was a problem hiding this comment.
To maintain consistency with how other commands are being updated in this PR, I suggest moving the help text from the docstring to a help parameter in the @app.command decorator and then removing the docstring.
| @app.command("add") | |
| async def add_provider( | |
| capability: typing.Annotated[ | |
| ModelCapability | None, typer.Argument(help="Which default model to change (llm/embedding)") | |
| ] = None, | |
| ): | |
| """Add a new model provider. [Admin only]""" | |
| @app.command("add", help="Add a new model provider. [Admin only]") | |
| async def add_provider( | |
| capability: typing.Annotated[ | |
| ModelCapability | None, typer.Argument(help="Which default model to change (llm/embedding)") | |
| ] = None, | |
| ): |
|
|
||
| @model_provider_app.command("remove | rm | delete") | ||
| @model_provider_app.command("remove | rm | delete", help="Remove a model provider [Admin only]") | ||
| @app.command("remove | rm | delete") |
There was a problem hiding this comment.
The model provider remove command has help text, but it seems the model remove command is missing it. For completeness and consistency, you should add help text for the command registered with the main app as well.
| @app.command("remove | rm | delete") | |
| @app.command("remove | rm | delete", help="Remove a model provider [Admin only]") |
Summary
Linked Issues
Fixes #1766
Documentation
If this PR adds new feature or changes existing. Make sure documentation is adjusted accordingly. If the docs is not needed, please explain why.