feat(ui): use ClientFactory instead of A2AClient#1828
Conversation
Signed-off-by: Petr Bulánek <bulanek.petr@gmail.com>
Summary of ChangesHello @PetrBulanek, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the A2A client creation mechanism within the UI, transitioning from the deprecated Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request migrates the A2A client creation from the deprecated A2AClient to the new ClientFactory, which is a great update. The changes look mostly correct, but I've found a significant issue with how API URLs are constructed, which could break deployments that serve the application from a sub-path. My review includes two related suggestions to fix this: one in getBaseUrl.ts to correctly include the application's base path, and another in agent-card.ts to ensure the path is resolved correctly. After these changes, the migration should be solid.
Signed-off-by: Petr Bulánek <bulanek.petr@gmail.com>
Summary
Migrate A2A client creation from deprecated
A2AClienttoClientFactory.Linked Issues
Closes: #1795
Documentation
If this PR adds new feature or changes existing. Make sure documentation is adjusted accordingly. If the docs is not needed, please explain why.