Skip to content

feat(ui): use ClientFactory instead of A2AClient#1828

Merged
tomkis merged 2 commits intomainfrom
ui/a2a-client-factory
Jan 16, 2026
Merged

feat(ui): use ClientFactory instead of A2AClient#1828
tomkis merged 2 commits intomainfrom
ui/a2a-client-factory

Conversation

@PetrBulanek
Copy link
Contributor

Summary

Migrate A2A client creation from deprecated A2AClient to ClientFactory.

Linked Issues

Closes: #1795

Documentation

  • No Docs Needed:

If this PR adds new feature or changes existing. Make sure documentation is adjusted accordingly. If the docs is not needed, please explain why.

Signed-off-by: Petr Bulánek <bulanek.petr@gmail.com>
@PetrBulanek PetrBulanek requested review from kapetr and tomkis January 16, 2026 08:23
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 16, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @PetrBulanek, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the A2A client creation mechanism within the UI, transitioning from the deprecated A2AClient to the more robust and modern ClientFactory. This change involves updating client instantiation logic, modernizing related type definitions, and streamlining task status checks, ultimately enhancing the maintainability and future-proofing of the client-side A2A integration.

Highlights

  • Client Factory Adoption: The core change involves migrating from the deprecated A2AClient to the new ClientFactory for creating A2A clients, ensuring future compatibility and adherence to updated SDK patterns.
  • Type Modernization: Updated type imports and usage, specifically replacing A2AClient with Client and GetTaskResponse with Task, reflecting the new SDK structure.
  • Simplified Task Status Check: The logic for checking task cancellation status has been streamlined by removing the isGetTaskSuccessResponse utility and directly accessing task?.status.state.
  • Base URL Constant Update: The getBaseUrl utility now correctly references BASE_URL instead of BASE_PATH, aligning with consistent constant naming.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the A2A client creation from the deprecated A2AClient to the new ClientFactory, which is a great update. The changes look mostly correct, but I've found a significant issue with how API URLs are constructed, which could break deployments that serve the application from a sub-path. My review includes two related suggestions to fix this: one in getBaseUrl.ts to correctly include the application's base path, and another in agent-card.ts to ensure the path is resolved correctly. After these changes, the migration should be solid.

Signed-off-by: Petr Bulánek <bulanek.petr@gmail.com>
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 16, 2026
@tomkis tomkis merged commit 8f778b0 into main Jan 16, 2026
8 checks passed
@tomkis tomkis deleted the ui/a2a-client-factory branch January 16, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI - Migrate A2A client from deprecated A2AClient to ClientFactory

2 participants