Skip to content

feat(ui): add validation for form fields#1934

Merged
PetrBulanek merged 3 commits intomainfrom
ui/form-fields-validation
Jan 28, 2026
Merged

feat(ui): add validation for form fields#1934
PetrBulanek merged 3 commits intomainfrom
ui/form-fields-validation

Conversation

@PetrBulanek
Copy link
Contributor

Summary

This PR fixes inconsistent required-field validation across UI form components.

  • Aligns UI field implementations with SDK required definitions.
  • Ensures all required fields enforce validation.
  • Adds consistent invalid states and inline error messages for missing required input.
  • Prevents submission when required fields are empty.

Users now receive clear, consistent visual feedback for required fields across all form types, eliminating silent failures and invalid submissions.

Linked Issues

Closes: #1900

Documentation

  • No Docs Needed:

If this PR adds new feature or changes existing. Make sure documentation is adjusted accordingly. If the docs is not needed, please explain why.

Signed-off-by: Petr Bulánek <bulanek.petr@gmail.com>
Signed-off-by: Petr Bulánek <bulanek.petr@gmail.com>
@PetrBulanek PetrBulanek requested review from kapetr and tomkis January 28, 2026 13:40
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 28, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @PetrBulanek, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the robustness and user experience of UI form components by implementing consistent and comprehensive required-field validation. It standardizes how validation rules are applied, ensures clear visual feedback for users, and prevents invalid data submissions, leading to a more reliable and intuitive form interaction across the application.

Highlights

  • Consistent Validation: Inconsistent required-field validation across UI form components has been fixed, aligning UI field implementations with SDK required definitions.
  • Enhanced User Feedback: All required fields now enforce validation, displaying consistent invalid states and inline error messages for missing input.
  • Submission Prevention: Form submission is now prevented when required fields are empty, improving data integrity and user experience.
  • New Validation Hook: A new useFormFieldValidation hook has been introduced to centralize and standardize validation logic across various form fields.
  • Dependency Update: The cachetools dependency has been added to uv.lock files for both agentstack-cli and agentstack-server.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@PetrBulanek PetrBulanek changed the title UI/form fields validation feat(ui): add validation for form fields Jan 28, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request does a great job of implementing consistent required-field validation across the UI form components. The introduction of the useFormFieldValidation hook is an excellent abstraction that centralizes validation logic and improves maintainability. The changes ensure that forms provide clear, immediate feedback to the user, preventing invalid submissions. The code is well-structured and the refactoring of SDK schemas is clean. I've included a couple of suggestions to further improve code quality and component design.

Copy link
Contributor

@kapetr kapetr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. One thing though - I'd consider adding an indicator for required fields and/or not disabling the submit button. It seems to me that in the current state, the user has no infmation about why he can't submit the form.

Comment on lines +57 to +59
if (prevFilesKey === filesKey) {
return;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why is this necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The useEffect calls onChange with the uploaded files to make the form stay in sync with them. And it ran on the initial render as well, which triggered the validation and "This field is required." showed immediately. This seemed like a good solution to me. But maybe you can think of something better, so be sure to let me know. :-)

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 28, 2026
Signed-off-by: Petr Bulánek <bulanek.petr@gmail.com>
@PetrBulanek PetrBulanek merged commit 07a9aad into main Jan 28, 2026
8 of 10 checks passed
@PetrBulanek PetrBulanek deleted the ui/form-fields-validation branch January 28, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

UI - Required form fields lack validation feedback

2 participants