feat(ui): add validation for form fields#1934
Conversation
Signed-off-by: Petr Bulánek <bulanek.petr@gmail.com>
Signed-off-by: Petr Bulánek <bulanek.petr@gmail.com>
Summary of ChangesHello @PetrBulanek, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the robustness and user experience of UI form components by implementing consistent and comprehensive required-field validation. It standardizes how validation rules are applied, ensures clear visual feedback for users, and prevents invalid data submissions, leading to a more reliable and intuitive form interaction across the application. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request does a great job of implementing consistent required-field validation across the UI form components. The introduction of the useFormFieldValidation hook is an excellent abstraction that centralizes validation logic and improves maintainability. The changes ensure that forms provide clear, immediate feedback to the user, preventing invalid submissions. The code is well-structured and the refactoring of SDK schemas is clean. I've included a couple of suggestions to further improve code quality and component design.
kapetr
left a comment
There was a problem hiding this comment.
Looks great. One thing though - I'd consider adding an indicator for required fields and/or not disabling the submit button. It seems to me that in the current state, the user has no infmation about why he can't submit the form.
| if (prevFilesKey === filesKey) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Just curious, why is this necessary?
There was a problem hiding this comment.
The useEffect calls onChange with the uploaded files to make the form stay in sync with them. And it ran on the initial render as well, which triggered the validation and "This field is required." showed immediately. This seemed like a good solution to me. But maybe you can think of something better, so be sure to let me know. :-)
Signed-off-by: Petr Bulánek <bulanek.petr@gmail.com>
Summary
This PR fixes inconsistent required-field validation across UI form components.
Users now receive clear, consistent visual feedback for required fields across all form types, eliminating silent failures and invalid submissions.
Linked Issues
Closes: #1900
Documentation
If this PR adds new feature or changes existing. Make sure documentation is adjusted accordingly. If the docs is not needed, please explain why.