Skip to content

fix(sdk): remove catalog devDependencies #1936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PetrBulanek merged 2 commits into from
Jan 29, 2026
Merged

fix(sdk): remove catalog devDependencies #1936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8524341
fix(sdk): remove catalog devDependencies
PetrBulanek Jan 28, 2026
6de4e0d
fixup! fix(sdk): remove catalog devDependencies
PetrBulanek Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/agentstack-sdk-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,11 @@
},
"devDependencies": {
"@i-am-bee/lint-config": "workspace:*",
"eslint": "catalog:",
"eslint": "^9.39.1",
"microbundle": "^0.15.1",
"prettier": "catalog:",
"prettier": "^3.7.4",
"rimraf": "^6.0.1",
"typescript": "catalog:"
"typescript": "^5.9.3"
Comment on lines +81 to +85
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change removes the usage of pnpm catalogs for eslint, prettier, and typescript, pinning them to specific versions instead. While this works, it moves away from the centralized dependency management provided by the catalog. Using the catalog (catalog:) ensures that these development dependencies are consistent across all packages in the monorepo and can be updated in one place. Was there a specific reason to stop using the catalog for this package? If not, it would be better for long-term maintainability to revert to using the catalog: specifier.

Suggested change
"eslint": "^9.39.1",
"microbundle": "^0.15.1",
"prettier": "catalog:",
"prettier": "^3.7.4",
"rimraf": "^6.0.1",
"typescript": "catalog:"
"typescript": "^5.9.3"
"eslint": "catalog:",
"microbundle": "^0.15.1",
"prettier": "catalog:",
"rimraf": "^6.0.1",
"typescript": "catalog:"

},
"packageManager": "pnpm@9.9.0"
}
6 changes: 3 additions & 3 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.