Skip to content

fix(sdk): remove catalog devDependencies#1936

Merged
PetrBulanek merged 2 commits intomainfrom
fix/sdk-catalog-deps
Jan 29, 2026
Merged

fix(sdk): remove catalog devDependencies#1936
PetrBulanek merged 2 commits intomainfrom
fix/sdk-catalog-deps

Conversation

@PetrBulanek
Copy link
Contributor

Summary

Removing catalog devDependencies in client SDK.

Documentation

  • No Docs Needed:

If this PR adds new feature or changes existing. Make sure documentation is adjusted accordingly. If the docs is not needed, please explain why.

Signed-off-by: Petr Bulánek <bulanek.petr@gmail.com>
Signed-off-by: Petr Bulánek <bulanek.petr@gmail.com>
@PetrBulanek PetrBulanek requested review from kapetr and tomkis January 28, 2026 14:40
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 28, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @PetrBulanek, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the dependency management within the agentstack-sdk-ts client by replacing abstract catalog: dependency specifiers with concrete semantic version ranges for key development tools. This change aims to improve build consistency and clarity regarding the exact versions of eslint, prettier, and typescript used in the project, ensuring a more predictable development environment.

Highlights

  • Dependency Management: Updated eslint, prettier, and typescript devDependencies in apps/agentstack-sdk-ts/package.json from catalog: specifiers to explicit semantic version ranges (^9.39.1, ^3.7.4, ^5.9.3 respectively).
  • Lockfile Update: The pnpm-lock.yaml file was automatically updated to reflect the new explicit version specifiers for eslint, prettier, and typescript.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the use of pnpm's catalog: specifier for eslint, prettier, and typescript in the agentstack-sdk-ts package, replacing them with specific version ranges. While this change is functional, it deviates from the monorepo's strategy of centralized dependency management via catalogs. I've left a comment suggesting to revert this change to maintain consistency and ease of maintenance across the repository, unless there's a compelling reason for this deviation.

Comment on lines +81 to +85
"eslint": "^9.39.1",
"microbundle": "^0.15.1",
"prettier": "catalog:",
"prettier": "^3.7.4",
"rimraf": "^6.0.1",
"typescript": "catalog:"
"typescript": "^5.9.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change removes the usage of pnpm catalogs for eslint, prettier, and typescript, pinning them to specific versions instead. While this works, it moves away from the centralized dependency management provided by the catalog. Using the catalog (catalog:) ensures that these development dependencies are consistent across all packages in the monorepo and can be updated in one place. Was there a specific reason to stop using the catalog for this package? If not, it would be better for long-term maintainability to revert to using the catalog: specifier.

Suggested change
"eslint": "^9.39.1",
"microbundle": "^0.15.1",
"prettier": "catalog:",
"prettier": "^3.7.4",
"rimraf": "^6.0.1",
"typescript": "catalog:"
"typescript": "^5.9.3"
"eslint": "catalog:",
"microbundle": "^0.15.1",
"prettier": "catalog:",
"rimraf": "^6.0.1",
"typescript": "catalog:"

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 29, 2026
@PetrBulanek PetrBulanek merged commit 97f2605 into main Jan 29, 2026
8 checks passed
@PetrBulanek PetrBulanek deleted the fix/sdk-catalog-deps branch January 29, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants