fix(sdk): remove catalog devDependencies#1936
Conversation
Signed-off-by: Petr Bulánek <bulanek.petr@gmail.com>
Signed-off-by: Petr Bulánek <bulanek.petr@gmail.com>
Summary of ChangesHello @PetrBulanek, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the dependency management within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request removes the use of pnpm's catalog: specifier for eslint, prettier, and typescript in the agentstack-sdk-ts package, replacing them with specific version ranges. While this change is functional, it deviates from the monorepo's strategy of centralized dependency management via catalogs. I've left a comment suggesting to revert this change to maintain consistency and ease of maintenance across the repository, unless there's a compelling reason for this deviation.
| "eslint": "^9.39.1", | ||
| "microbundle": "^0.15.1", | ||
| "prettier": "catalog:", | ||
| "prettier": "^3.7.4", | ||
| "rimraf": "^6.0.1", | ||
| "typescript": "catalog:" | ||
| "typescript": "^5.9.3" |
There was a problem hiding this comment.
This change removes the usage of pnpm catalogs for eslint, prettier, and typescript, pinning them to specific versions instead. While this works, it moves away from the centralized dependency management provided by the catalog. Using the catalog (catalog:) ensures that these development dependencies are consistent across all packages in the monorepo and can be updated in one place. Was there a specific reason to stop using the catalog for this package? If not, it would be better for long-term maintainability to revert to using the catalog: specifier.
| "eslint": "^9.39.1", | |
| "microbundle": "^0.15.1", | |
| "prettier": "catalog:", | |
| "prettier": "^3.7.4", | |
| "rimraf": "^6.0.1", | |
| "typescript": "catalog:" | |
| "typescript": "^5.9.3" | |
| "eslint": "catalog:", | |
| "microbundle": "^0.15.1", | |
| "prettier": "catalog:", | |
| "rimraf": "^6.0.1", | |
| "typescript": "catalog:" |
Summary
Removing catalog devDependencies in client SDK.
Documentation
If this PR adds new feature or changes existing. Make sure documentation is adjusted accordingly. If the docs is not needed, please explain why.