Skip to content

fix(cli): better error message when docker missing#2049

Merged
JanPokorny merged 1 commit intomainfrom
janpokorny/fix-agentstack-cli-improve-error-message-on-missing-docker
Feb 9, 2026
Merged

fix(cli): better error message when docker missing#2049
JanPokorny merged 1 commit intomainfrom
janpokorny/fix-agentstack-cli-improve-error-message-on-missing-docker

Conversation

@JanPokorny
Copy link
Collaborator

@JanPokorny JanPokorny commented Feb 9, 2026

Summary

Linked Issues

Documentation

  • No Docs Needed:

If this PR adds new feature or changes existing. Make sure documentation is adjusted accordingly. If the docs is not needed, please explain why.

Signed-off-by: Jan Pokorný <JenomPokorny@gmail.com>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @JanPokorny, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the local agent build process by removing an unnecessary preliminary check for Docker's presence. The change aims to streamline error reporting, ensuring that users receive more accurate and direct feedback when Docker is unavailable, rather than a generic "Checking docker" message followed by a less informative failure.

Highlights

  • Docker Check Removal: The explicit await run_command(["which", "docker"], "Checking docker") call has been removed from the client_side_build function. This change is intended to prevent a potentially misleading "Checking docker" message and allow subsequent Docker commands to fail more gracefully, providing a clearer error message when Docker is not found.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • apps/agentstack-cli/src/agentstack_cli/commands/build.py
    • Removed the await run_command(["which", "docker"], "Checking docker") line from the client_side_build function.
Activity
  • No specific review comments or activity have been provided in the context.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 9, 2026
@JanPokorny JanPokorny merged commit fc5317f into main Feb 9, 2026
9 of 10 checks passed
@JanPokorny JanPokorny deleted the janpokorny/fix-agentstack-cli-improve-error-message-on-missing-docker branch February 9, 2026 11:36
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the error handling for when Docker is not installed. By removing the explicit which docker check, the code now relies on the subsequent docker build command to fail if the Docker executable is not found. The run_command utility already handles the resulting FileNotFoundError gracefully, providing a clear and user-friendly error message. This change not only simplifies the code but also enhances portability, as which is not universally available across all operating systems. This is a solid improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant