fix(cli): better error message when docker missing#2049
Conversation
Signed-off-by: Jan Pokorný <JenomPokorny@gmail.com>
Summary of ChangesHello @JanPokorny, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the local agent build process by removing an unnecessary preliminary check for Docker's presence. The change aims to streamline error reporting, ensuring that users receive more accurate and direct feedback when Docker is unavailable, rather than a generic "Checking docker" message followed by a less informative failure. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request improves the error handling for when Docker is not installed. By removing the explicit which docker check, the code now relies on the subsequent docker build command to fail if the Docker executable is not found. The run_command utility already handles the resulting FileNotFoundError gracefully, providing a clear and user-friendly error message. This change not only simplifies the code but also enhances portability, as which is not universally available across all operating systems. This is a solid improvement.
Summary
Linked Issues
Documentation
If this PR adds new feature or changes existing. Make sure documentation is adjusted accordingly. If the docs is not needed, please explain why.