Merged
Conversation
jezekra1
force-pushed
the
add-procrastinate
branch
from
4d12b51 to
e278219
Compare
jezekra1
force-pushed
the
add-vector-stores
branch
13 times, most recently
from
e6bca4b to
c62fe91
Compare
jezekra1
force-pushed
the
add-vector-stores
branch
from
c62fe91 to
cf24c0f
Compare
jezekra1
force-pushed
the
add-vector-stores
branch
5 times, most recently
from
5c25517 to
1460d6b
Compare
xjacka
reviewed
Jun 30, 2025
| class SearchRequest(BaseModel): | ||
| """Request to search a vector store.""" | ||
|
|
||
| query_vector: list[float] = Field(None, description="Vector to search for") |
Contributor
There was a problem hiding this comment.
query and max_num_results to be aligned with OpenAI?
Collaborator
|
Are we targeting OpenAI API compatibility (https://platform.openai.com/docs/api-reference/vector-stores)? Maybe we should (for simplicity), in which case we should keep the API together with |
Collaborator
Author
|
It's not compatible with the way we designed it. The openai API is more high level - works with files not vectors. We wanted to give users more control over the data, so our implementation is more like "simplified perplexity" api |
Signed-off-by: Radek Ježek <radek.jezek@ibm.com>
jezekra1
force-pushed
the
add-vector-stores
branch
from
5164720 to
14e766f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #625