Skip to content

Fixes #171 #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
edvinh wants to merge 1 commit into from
Closed

Fixes #171 #172

edvinh wants to merge 1 commit into from

Conversation

@edvinh
Copy link

@edvinh edvinh commented Sep 30, 2019 •
edited
Loading

Added resetSelectedIndex to the Suggestions component. It resets selectedIndex state when suggestions are filtered and the index is out of bounds.

@coveralls
Copy link

coveralls commented Sep 30, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-1.1%) to 98.315% when pulling 2099e2d on edvinh:master into c35f170 on i-like-robots:master.

@coveralls
Copy link

coveralls commented Sep 30, 2019

Coverage Status

Coverage decreased (-1.1%) to 98.315% when pulling 425064b on edvinh:master into c35f170 on i-like-robots:master.

@i-like-robots
Copy link
Owner

i-like-robots commented Oct 12, 2019

Thank you so much for submitting this but I'm closing it in favour of #175.

@edvinh
Copy link
Author

edvinh commented Oct 12, 2019

Great! #175 is a more elegant solution anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edvinh @coveralls @i-like-robots