Skip to content

only draw unlock-indicator if not visible#33

Closed
koebi wants to merge 2 commits intoi3:masterfrom
koebi:master
Closed

only draw unlock-indicator if not visible#33
koebi wants to merge 2 commits intoi3:masterfrom
koebi:master

Conversation

@koebi
Copy link
Copy Markdown
Contributor

@koebi koebi commented Sep 5, 2015

No description provided.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize you’re not changing this part of the code, but currently we have:

if (xr_screens > 0) {
  for (int screen = 0; screen < xr_screens; screen++) {
    // …
  }
} else {
  // else
}

And to save one level of indentation (which will be good to make the code you’re adding more readable), we can pull out the for loop like so:

for (int screen = 0; screen < xr_screens; screen++) {
  // …
}
if (xr_screens == 0) {
  // else
}

@stapelberg
Copy link
Copy Markdown
Member

Also, can you squash your commits please? (git rebase -i, then git push -f)

@Airblader
Copy link
Copy Markdown
Member

Closing due to inactivity.

@Airblader Airblader closed this Feb 13, 2016
mortie pushed a commit to mortie/i3lock that referenced this pull request May 24, 2019
Implements positioning of the unlock indicator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants