Feature/diamond #231
Closed
Feature/diamond #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iamond-unit-tests
* chore: Remove ENS deployment and related files from the project * chore: Remove ENS integration and update changelog and documentation * chore: Remove ENS contracts and related dependencies from package-lock.json * Update CHANGELOG.md Co-authored-by: gfournieriExec <100280020+gfournieriExec@users.noreply.github.com> * fix: Remove reference to ENS contracts in Hardhat config * chore: Remove ENS integration from Registry and RegistryEntry contracts --------- Co-authored-by: gfournieriExec <100280020+gfournieriExec@users.noreply.github.com>
* refactor: rename ERC1538Proxy to DiamondProxy across the codebase * Apply suggestions from code review Co-authored-by: Zied Guesmi <26070035+zguesmi@users.noreply.github.com> * fix: Update scripts/upgrades/upgrade-helper.ts Co-authored-by: Robin Le Caignec <72495599+Le-Caignec@users.noreply.github.com> --------- Co-authored-by: Zied Guesmi <26070035+zguesmi@users.noreply.github.com> Co-authored-by: Robin Le Caignec <72495599+Le-Caignec@users.noreply.github.com>
* feat: Migrate from delegateSmart contract to facet naming * feat: Update contract references from delegate to facet naming across multiple files * feat: Remove DelegateBase and DelegateBase.v8 contracts * feat: Update contract references from delegate to facet naming in multiple files * fix: Correct typo in changelog for ERC1538 architecture renaming * Update comment --------- Co-authored-by: Zied <26070035+zguesmi@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+28
to
+30
| function _msgSender() internal view returns (address) { | ||
| return msg.sender; | ||
| } |
Check warning
Code scanning / Slither
Dead-code Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.