-
Notifications
You must be signed in to change notification settings - Fork 14
feat: Target latest EVM version #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/diamond #239 +/- ##
================================================
Coverage 83.60% 83.60%
================================================
Files 38 38
Lines 1214 1214
Branches 225 225
================================================
Hits 1015 1015
Misses 199 199 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR targets the latest EVM version by removing the hardcoded Berlin hardfork configuration and updates field naming consistency across the codebase.
- Removes EVM version constraint that was targeting Berlin hardfork to allow targeting latest EVM version
- Renames
EIP712DOMAIN_SEPARATOR
tom_eip712DomainSeparator
for consistent naming convention - Updates comments and TODOs to reflect current migration status
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
hardhat.config.ts | Removes Berlin hardfork EVM version constraint to target latest version |
contracts/Store.sol | Renames EIP712DOMAIN_SEPARATOR field to m_eip712DomainSeparator |
contracts/Store.v8.sol | Renames EIP712DOMAIN_SEPARATOR field to m_eip712DomainSeparator |
contracts/facets/*.sol | Updates references to use new m_eip712DomainSeparator field name |
test/byContract/IexecConfiguration/IexecConfiguration.test.ts | Updates comment to reflect new field name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good 👍🏻
Migration steps:
receive
andfallback
behavior inDiamond.sol
Module
toFacet
in contracts namesDiamond.sol
feature/diamond
indevelop