Skip to content

Conversation

zguesmi
Copy link
Member

@zguesmi zguesmi commented Jul 26, 2025

Migration steps:

  • Migrate src files (minimal changes)
  • Modify receive and fallback behavior in Diamond.sol
  • Rename all 1538 to 2535 in contracts and rename Module to Facet in contracts names
  • Add unit tests for Diamond.sol
  • Remove ENSIntegration modules/functions
  • Update all facets to use namespaces app storage.
  • Rename only ✔️ feat: Use namespaced storage #236
  • Fix compilation and tests ✔️ fix: Fix build with new storage layout #237
  • Update contracts file tree.
  • Target latest EVM version instead of Berlin
  • Merge feature/diamond in develop
  • Merge PR Update deployment CI #228
  • Set admin in deployment script
  • Update docs (soldoc, diagrams, ...)

Copy link

codecov bot commented Jul 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.60%. Comparing base (dffdcc1) to head (e1d26e7).
⚠️ Report is 4 commits behind head on feature/diamond.

Additional details and impacted files
@@               Coverage Diff                @@
##           feature/diamond     #239   +/-   ##
================================================
  Coverage            83.60%   83.60%           
================================================
  Files                   38       38           
  Lines                 1214     1214           
  Branches               225      225           
================================================
  Hits                  1015     1015           
  Misses                 199      199           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zguesmi zguesmi marked this pull request as ready for review July 28, 2025 09:30
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR targets the latest EVM version by removing the hardcoded Berlin hardfork configuration and updates field naming consistency across the codebase.

  • Removes EVM version constraint that was targeting Berlin hardfork to allow targeting latest EVM version
  • Renames EIP712DOMAIN_SEPARATOR to m_eip712DomainSeparator for consistent naming convention
  • Updates comments and TODOs to reflect current migration status

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
hardhat.config.ts Removes Berlin hardfork EVM version constraint to target latest version
contracts/Store.sol Renames EIP712DOMAIN_SEPARATOR field to m_eip712DomainSeparator
contracts/Store.v8.sol Renames EIP712DOMAIN_SEPARATOR field to m_eip712DomainSeparator
contracts/facets/*.sol Updates references to use new m_eip712DomainSeparator field name
test/byContract/IexecConfiguration/IexecConfiguration.test.ts Updates comment to reflect new field name

@zguesmi zguesmi requested a review from Le-Caignec July 28, 2025 09:30
Copy link
Contributor

@Le-Caignec Le-Caignec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good 👍🏻

Base automatically changed from feature/contracts-file-tree to feature/diamond July 28, 2025 10:17
@zguesmi zguesmi merged commit b173aef into feature/diamond Jul 28, 2025
4 checks passed
@zguesmi zguesmi deleted the feature/evm-version branch July 28, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants