-
Notifications
You must be signed in to change notification settings - Fork 14
feat: Save IexecLibOrders_v5
in config file
#242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds functionality to save the IexecLibOrders_v5
contract address in the configuration file as part of the Diamond pattern migration. The main purpose is to enhance the deployment script to automatically capture and store both the Diamond proxy and IexecLibOrders_v5 addresses in the config.json file.
Key changes:
- Enhanced the update-config.ts script to save IexecLibOrders_v5 address alongside Diamond proxy address
- Removed explicit Promise return types from utility functions in favor of implicit returns
- Added workflow naming and minor formatting improvements
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
scripts/tools/update-config.ts | Enhanced to save IexecLibOrders_v5 address from deployments and improved logging |
utils/createOrders.ts | Removed explicit Promise return types from async functions |
utils/config.ts | Added TODO comments for future cleanup of DiamondProxy and IexecLibOrders_v5 config fields |
CHANGELOG.md | Added entry for the new IexecLibOrders_v5 config feature |
.github/workflows/main.yml | Added workflow name |
.github/workflows/deploy.yml | Added blank line and comment for hardhat issue fix |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #242 +/- ##
========================================
Coverage 83.66% 83.66%
========================================
Files 38 38
Lines 1218 1218
Branches 227 227
========================================
Hits 1019 1019
Misses 199 199 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Migration steps:
receive
andfallback
behavior inDiamond.sol
Module
toFacet
in contracts namesDiamond.sol
feature/diamond
indevelop
IexecLibOrders_v5
in config.json