Skip to content

Conversation

zguesmi
Copy link
Member

@zguesmi zguesmi commented Jul 28, 2025

Migration steps:

  • Migrate src files (minimal changes)
  • Modify receive and fallback behavior in Diamond.sol
  • Rename all 1538 to 2535 in contracts and rename Module to Facet in contracts names
  • Add unit tests for Diamond.sol
  • Remove ENSIntegration modules/functions
  • Update all facets to use namespaces app storage.
  • Rename only ✔️ feat: Use namespaced storage #236
  • Fix compilation and tests ✔️ fix: Fix build with new storage layout #237
  • Update contracts file tree.
  • Target latest EVM version instead of Berlin
  • Merge feature/diamond in develop
  • Merge PR Update deployment CI #228
  • Set admin in deployment script
  • Save IexecLibOrders_v5 in config.json
  • Update docs (soldoc, diagrams, ...)
image

@zguesmi zguesmi self-assigned this Jul 28, 2025
@zguesmi zguesmi marked this pull request as ready for review July 28, 2025 15:14
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds functionality to save the IexecLibOrders_v5 contract address in the configuration file as part of the Diamond pattern migration. The main purpose is to enhance the deployment script to automatically capture and store both the Diamond proxy and IexecLibOrders_v5 addresses in the config.json file.

Key changes:

  • Enhanced the update-config.ts script to save IexecLibOrders_v5 address alongside Diamond proxy address
  • Removed explicit Promise return types from utility functions in favor of implicit returns
  • Added workflow naming and minor formatting improvements

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
scripts/tools/update-config.ts Enhanced to save IexecLibOrders_v5 address from deployments and improved logging
utils/createOrders.ts Removed explicit Promise return types from async functions
utils/config.ts Added TODO comments for future cleanup of DiamondProxy and IexecLibOrders_v5 config fields
CHANGELOG.md Added entry for the new IexecLibOrders_v5 config feature
.github/workflows/main.yml Added workflow name
.github/workflows/deploy.yml Added blank line and comment for hardhat issue fix

Copy link

codecov bot commented Jul 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.66%. Comparing base (2475bdc) to head (248e9ad).
⚠️ Report is 12 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #242   +/-   ##
========================================
  Coverage    83.66%   83.66%           
========================================
  Files           38       38           
  Lines         1218     1218           
  Branches       227      227           
========================================
  Hits          1019     1019           
  Misses         199      199           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zguesmi zguesmi merged commit 11b00d0 into develop Jul 28, 2025
4 checks passed
@zguesmi zguesmi deleted the feature/orders-library branch July 28, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants