ci: Fix NPM publish workflow #297
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #297 +/- ##
=======================================
Coverage 84.85% 84.85%
=======================================
Files 37 37
Lines 1241 1241
Branches 235 235
=======================================
Hits 1053 1053
Misses 188 188 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the NPM package publishing workflow by correcting permission issues and adding support for automated prerelease versioning. The changes enable successful publication of both release candidate (RC) and stable versions to NPM.
Key Changes:
- Moved workflow permissions from top-level to job-level in
publish.ymlto fix the "Resource not accessible by integration" error - Added automated dist-tag determination to distinguish between RC and stable releases
- Introduced a
prereleasenpm script for manual RC version bumping
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/publish.yml |
Relocated permissions to job level, added dist-tag determination job, and configured tag parameter for reusable workflow |
package.json |
Updated version to 6.1.0-rc.5 and added prerelease script for RC versioning |
docs/README.md |
Added release documentation explaining automated releases and manual prerelease process, renamed section from "Formatting" to "Format" |
.github/workflows/upgrade-facets.yml |
Renamed job from build-and-test to pre-upgrade for consistency |
.github/workflows/deploy.yml |
Renamed job from build-and-test to pre-deploy for consistency |
.github/CODEOWNERS |
Added CODEOWNERS file defining code review responsibilities |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| @@ -0,0 +1,10 @@ | |||
| # Code owners are automatically requested to review when a pull request | |||
| # is opened (ready for review). | |||
| # See https://search.brave.com/search?q=About+code+owners+-+GitHub+Docs | |||
There was a problem hiding this comment.
The URL references a search engine query rather than directly linking to GitHub's official documentation. Consider using the direct documentation link: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
| # See https://search.brave.com/search?q=About+code+owners+-+GitHub+Docs | |
| # See https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners |
There was a problem hiding this comment.
I used the search link because documentation link could change and it was too long but I can change it back.
zguesmi
changed the title
|
|
||
| jobs: | ||
| build-and-test: | ||
| pre-publish: |
There was a problem hiding this comment.
why set a particular name for this wf ?
There was a problem hiding this comment.
It's to get clearer names here instead of the name repetition. It also helps better debug when there are issues.
2 participants
Error: Resource not accessible by integrationin actions/runs/18651832139/job/53181453759v6.1.0-rc.5✔️ : PoCo/actions/runs/18678697744@iexec/pocoversions: https://www.npmjs.com/package/@iexec/poco?activeTab=versions