Skip to content

Conversation

@zguesmi
Copy link
Member

@zguesmi zguesmi commented Nov 4, 2025

└── contracts
    └── tools
        └── TimelockController.sol

└── deployments
    └── avalancheFujiTestnet/

└── scripts
    ├── deploy-timelock.ts
    ├── ens/
    ├── scoreImporting/
    └── sponsoring/

Copilot AI review requested due to automatic review settings November 4, 2025 08:18
@zguesmi zguesmi self-assigned this Nov 4, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes unused TimelockController-related code and deployment artifacts. The changes clean up legacy deployment scripts, configuration references, and test network deployment files that are no longer needed in the current version of the project.

Key changes:

  • Removal of TimelockController deployment script and related npm command
  • Cleanup of deployment artifacts from the avalancheFujiTestnet test network
  • Removal of TimelockController exclusions from configuration files

Reviewed Changes

Copilot reviewed 37 out of 37 changed files in this pull request and generated no comments.

Show a summary per file
File Description
scripts/deploy-timelock.ts Removed deployment script for TimelockController contract
package.json Removed deploy:timelock npm script and file pattern exclusion
hardhat.config.ts Removed TimelockController from docgen exclude patterns
.github/workflows/main.yml Removed TimelockController deployment step from CI workflow
deployments/avalancheFujiTestnet/* Removed multiple deployment JSON files from test network
abis/human-readable-abis/contracts/tools/TimelockController.sol/* Removed TimelockController ABI file
scripts/scoreImporting/getWorker.py Removed Python script for importing worker scores
scripts/ens/*.sh Removed ENS configuration scripts for mainnet and goerli

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@zguesmi zguesmi marked this pull request as ready for review November 4, 2025 08:20
@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.53%. Comparing base (091319a) to head (3281155).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #314   +/-   ##
=======================================
  Coverage   96.53%   96.53%           
=======================================
  Files          32       32           
  Lines        1069     1069           
  Branches      213      213           
=======================================
  Hits         1032     1032           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gfournieriExec
Copy link
Contributor

gfournieriExec commented Nov 4, 2025

we have still ref to TimelockController__factory in 1_add-modules-to-proxy.ts or it's used now form OZ lib ?

Copilot AI review requested due to automatic review settings November 4, 2025 08:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 42 out of 42 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@zguesmi
Copy link
Member Author

zguesmi commented Nov 4, 2025

we have still ref to TimelockController__factory in 1_add-modules-to-proxy.ts or it's used now form OZ lib ?

Yes, it's still referenced in boost/ scripts, we will remove them after create the new proper upgrade script for the boost module.

@zguesmi zguesmi merged commit 3b28585 into main Nov 4, 2025
10 checks passed
@zguesmi zguesmi deleted the chore/clean-unused-files branch November 4, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants