Skip to content

fix: potential buffer overflows #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2025
Merged

fix: potential buffer overflows #9

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5da96cc
fix: potential buffer overflows
jbern0rd Jul 29, 2025
2cc7e8c
fix: improve conf validation
jbern0rd Jul 29, 2025
5393d91
fix: add checks against NULL values
jbern0rd Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 37 additions & 4 deletions cvmassistants/secretprovider/secret-provider-agent/src/secret_provider_agent.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,35 @@ char* get_secret_from_kbs_through_rats_tls(rats_tls_log_level_t log_level,
char* ip,
int port,
bool appid_flag) {

bool validation_error = false;
if (attester_type == NULL || strlen(attester_type) >= ENCLAVE_ATTESTER_TYPE_NAME_SIZE) {
LOG_ERROR("attester_type is NULL or exceeds maximum allowed size (%d)\n",
ENCLAVE_ATTESTER_TYPE_NAME_SIZE - 1);
validation_error = true;
}

if (verifier_type == NULL || strlen(verifier_type) >= ENCLAVE_VERIFIER_TYPE_NAME_SIZE) {
LOG_ERROR("verifier_type is NULL or exceeds maximum allowed size (%d)\n",
ENCLAVE_VERIFIER_TYPE_NAME_SIZE - 1);
validation_error = true;
}

if (tls_type == NULL || strlen(tls_type) >= TLS_TYPE_NAME_SIZE) {
LOG_ERROR("tls_type is NULL or exceeds maximum allowed size (%d)\n",
TLS_TYPE_NAME_SIZE - 1);
validation_error = true;
}

if (crypto_type == NULL || strlen(crypto_type) >= CRYPTO_TYPE_NAME_SIZE) {
LOG_ERROR("crypto_type is NULL or exceeds maximum allowed size (%d)\n",
CRYPTO_TYPE_NAME_SIZE - 1);
validation_error = true;
}

if (validation_error) {
return NULL;
}
rats_tls_conf_t conf;

memset(&conf, 0, sizeof(conf));
Expand All @@ -93,10 +122,14 @@ char* get_secret_from_kbs_through_rats_tls(rats_tls_log_level_t log_level,
}

conf.log_level = log_level;
strcpy(conf.attester_type, attester_type);
strcpy(conf.verifier_type, verifier_type);
strcpy(conf.tls_type, tls_type);
strcpy(conf.crypto_type, crypto_type);
strncpy(conf.attester_type, attester_type, ENCLAVE_ATTESTER_TYPE_NAME_SIZE - 1);
conf.attester_type[ENCLAVE_ATTESTER_TYPE_NAME_SIZE - 1] = '\0';
strncpy(conf.verifier_type, verifier_type, ENCLAVE_VERIFIER_TYPE_NAME_SIZE - 1);
conf.verifier_type[ENCLAVE_VERIFIER_TYPE_NAME_SIZE - 1] = '\0';
strncpy(conf.tls_type, tls_type, TLS_TYPE_NAME_SIZE - 1);
conf.tls_type[TLS_TYPE_NAME_SIZE - 1] = '\0';
strncpy(conf.crypto_type, crypto_type, CRYPTO_TYPE_NAME_SIZE - 1);
conf.crypto_type[CRYPTO_TYPE_NAME_SIZE - 1] = '\0';
conf.cert_algo = RATS_TLS_CERT_ALGO_DEFAULT;
if (mutual)
conf.flags |= RATS_TLS_CONF_FLAGS_MUTUAL;
Expand Down