feat: Add new Safe Wallet reusable workflow #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Le-Caignec
changed the title
…ME, workflow, and source code for consistency
…olete workflow file
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new reusable GitHub Actions workflow for proposing transactions to Safe (Gnosis Safe) multi-signature wallets. The implementation provides a complete solution for integrating Safe transaction proposals into CI/CD pipelines.
Key changes:
- Adds a complete Safe transaction workflow with Node.js action implementation
- Provides comprehensive documentation and usage examples
- Implements proper security practices for handling private keys
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
safe-transaction/src/index.js |
Core JavaScript implementation handling Safe transaction creation and proposal |
.github/workflows/safe-transaction.yml |
Reusable GitHub Actions workflow definition with inputs/outputs |
safe-transaction/package.json |
NPM package configuration with Safe SDK dependencies |
safe-transaction/README.md |
Comprehensive documentation with usage examples |
safe-transaction/version.txt |
Version tracking file |
safe-transaction/CHANGELOG.md |
Initial changelog entry |
safe-transaction/.gitignore |
Standard gitignore for Node.js projects |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
gfournierPro
approved these changes
Sep 29, 2025
…in transaction creation
…thersAdapter for improved functionality
…in transaction proposal
…sary dependencies and parameters
zguesmi
reviewed
Sep 30, 2025
Comment on lines
59
to
60
| # TODO: Only for testing, remove before merging | ||
| ref: feature/add-safe-transaction-reusable-workflow |
… for improved compatibility
…rocess with new API and Protocol Kits
Co-authored-by: Zied Guesmi <26070035+zguesmi@users.noreply.github.com>
Co-authored-by: Zied Guesmi <26070035+zguesmi@users.noreply.github.com>
Co-authored-by: Zied Guesmi <26070035+zguesmi@users.noreply.github.com>
Co-authored-by: Zied Guesmi <26070035+zguesmi@users.noreply.github.com>
Co-authored-by: Zied Guesmi <26070035+zguesmi@users.noreply.github.com>
Co-authored-by: Zied Guesmi <26070035+zguesmi@users.noreply.github.com>
Co-authored-by: Zied Guesmi <26070035+zguesmi@users.noreply.github.com>
- Created a new GitHub Actions workflow for proposing transactions to a Gnosis Safe multisig wallet. - Added inputs for RPC URL, Safe address, transaction target, value, and data. - Implemented job steps for checking out the repository, setting up Node.js, installing dependencies, building the action, and proposing the transaction. - Included a README with usage instructions and a changelog. - Added TypeScript configuration and source code for the action. - Created .gitignore to exclude unnecessary files and directories. - Initialized package.json and package-lock.json for dependency management. - Added version tracking with version.txt.
…t variable structure and enhance validation
gfournierPro
reviewed
Oct 6, 2025
gfournierPro
reviewed
Oct 6, 2025
|
|
||
| core.info("📝 Creating Safe transaction..."); | ||
|
|
||
| // Create the transaction |
Contributor
There was a problem hiding this comment.
what is the difference with the above comment // Create transaction
Those comments seems a little redondant since the actions are clear
Contributor
There was a problem hiding this comment.
Thanks, you can remove all redondant comments, unless you don't feel confortable
gfournierPro
reviewed
Oct 6, 2025
zguesmi
reviewed
Oct 6, 2025
Co-authored-by: Zied Guesmi <26070035+zguesmi@users.noreply.github.com>
Co-authored-by: Zied Guesmi <26070035+zguesmi@users.noreply.github.com>
Co-authored-by: Zied Guesmi <26070035+zguesmi@users.noreply.github.com>
Co-authored-by: Zied Guesmi <26070035+zguesmi@users.noreply.github.com>
…s://github.com/iExecBlockchainComputing/github-actions-workflows into feature/add-safe-transaction-reusable-workflow
gfournierPro
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Safe Transaction Proposer Reusable Workflow
Summary
Adds a reusable GitHub Actions workflow to create and propose transactions to Safe multi-signature wallets.
Technical Details
.github/workflows/safe-transaction.ymlUsage