feat: add isolated GitHub two-instance E2E workflow#52
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive sandbox-first workflow and an automated end-to-end (E2E) test harness for the opencode-sync project. Key additions include a two-instance GitHub integration test script, environment setup scripts, and updated documentation for the Codex environment. The PR also refines the prompt templates for the sync-init and sync-link commands. Review feedback suggests improving the safety of command-line string construction using the shlex module, ensuring pgrep is included in preflight dependency checks, and removing unnecessary backslashes from escaped quotes in markdown templates to prevent literal interpretation by LLMs.
Updated the description for the opencode-sync-sandbox skill to clarify its purpose and usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/so they are not Codex-specificopencode servecleanupsrc/**/*.test.tsso.memory/artifacts do not pollute repo test runsValidation
python3 -m py_compile scripts/e2e/github_two_instance.pybun run checkbun testbun run buildpython3 scripts/e2e/github_two_instance.py --keep-artifacts