Skip to content

feat: add isolated GitHub two-instance E2E workflow#52

Merged
iHildy merged 4 commits into
mainfrom
ian/implement-opencode-sync-e2e
Apr 12, 2026
Merged

feat: add isolated GitHub two-instance E2E workflow#52
iHildy merged 4 commits into
mainfrom
ian/implement-opencode-sync-e2e

Conversation

@iHildy
Copy link
Copy Markdown
Owner

@iHildy iHildy commented Apr 12, 2026

Summary

  • move environment bootstrap and E2E harness scripts to top-level scripts/ so they are not Codex-specific
  • add hardened two-instance GitHub E2E harness with per-run sandbox isolation, dynamic ports, plugin packaging, and strict cleanup guards
  • update sandbox skill/docs/env wiring and README usage examples for setup + E2E workflow
  • add process-group/port-based teardown hardening for opencode serve cleanup
  • scope vitest to src/**/*.test.ts so .memory/ artifacts do not pollute repo test runs

Validation

  • python3 -m py_compile scripts/e2e/github_two_instance.py
  • bun run check
  • bun test
  • bun run build
  • python3 scripts/e2e/github_two_instance.py --keep-artifacts
  • parallel run test with two concurrent harness invocations from separate worktrees

@iHildy iHildy self-assigned this Apr 12, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a comprehensive sandbox-first workflow and an automated end-to-end (E2E) test harness for the opencode-sync project. Key additions include a two-instance GitHub integration test script, environment setup scripts, and updated documentation for the Codex environment. The PR also refines the prompt templates for the sync-init and sync-link commands. Review feedback suggests improving the safety of command-line string construction using the shlex module, ensuring pgrep is included in preflight dependency checks, and removing unnecessary backslashes from escaped quotes in markdown templates to prevent literal interpretation by LLMs.

Comment thread scripts/e2e/common.py
Comment thread scripts/e2e/common.py Outdated
Comment thread scripts/e2e/github_two_instance.py Outdated
Comment thread src/command/sync-init.md Outdated
Comment thread src/command/sync-link.md Outdated
iHildy and others added 2 commits April 11, 2026 19:49
Updated the description for the opencode-sync-sandbox skill to clarify its purpose and usage.
@iHildy iHildy merged commit e5c338f into main Apr 12, 2026
3 checks passed
@iHildy iHildy deleted the ian/implement-opencode-sync-e2e branch April 12, 2026 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant