Skip to content

Follow the ILD_l4_v02 calorimeter collections update to fix the ILD … #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gaede merged 1 commit into from
Sep 14, 2017
Merged

Follow the ILD_l4_v02 calorimeter collections update to fix the ILD … #5

gaede merged 1 commit into from
Sep 14, 2017

Conversation

@shaojunlu
Copy link
Contributor

@shaojunlu shaojunlu commented Aug 28, 2017 •
edited
Loading

…calorimeter collections name in ced2go template.

BEGINRELEASENOTES

  • Update the ced2go template for ILD_l4_v02.
    • add the Ecal and Hcal collection names from ILD_l4_v02.
    • remove duplicated LumiCalCollection.

ENDRELEASENOTES

@shaojunlu
Copy link
Contributor Author

shaojunlu commented Aug 28, 2017

@andresailer @webermat I have updated the calorimeter collections name for ILD_l4_v02.
Would you please have a look at this CED template file "ced2go-template-DD4.xml"?
Is it OK for CLIC about the modification?

@andresailer
Copy link
Contributor

andresailer commented Aug 28, 2017

We have our CED template in CLICPerformance:
https://github.com/iLCSoft/CLICPerformance/blob/master/Visualisation/CLIC_o3_v06_CED/ced2go-template-DD4.xml

@shaojunlu
Copy link
Contributor Author

shaojunlu commented Aug 29, 2017

@andresailer Thank you very much!
We will focus on the ILD_l4_v02 for the default template.

gaede
gaede reviewed Sep 14, 2017
View reviewed changes
Copy link
Contributor

@gaede gaede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we leave the old collection names in, so that we can use the new viewer also for older files ?

@shaojunlu
Copy link
Contributor Author

shaojunlu commented Sep 14, 2017

@gaede Yes, we could leave the old collection names in if you wish. They will not show up if they are not used by our current ILD_l4_v02.

@gaede
Copy link
Contributor

gaede commented Sep 14, 2017

Yes, I think this would be useful ...

@shaojunlu
Follow the ILD_l4_v02 calorimeter collections update to fix the ILD …
db89ade 
…calorimeter collections name in ced2go template.
@gaede gaede merged commit 127f308 into iLCSoft:master Sep 14, 2017
@shaojunlu shaojunlu deleted the FixILDCaloColName branch March 7, 2018 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rete rete rete approved these changes

@gaede gaede gaede approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shaojunlu @andresailer @gaede @rete