Resurrect tracking performance scripts#43
Merged
Conversation
tmadlener
reviewed
Mar 3, 2026
Contributor
tmadlener
left a comment
tmadlener
left a comment
There was a problem hiding this comment.
Is ILDPerformance built as part of a regular Key4hep stack by any chance?
Comment on lines
+8
to
+10
| ILCSOFTVER=v02-03-04 | ||
|
|
||
| . /afs/desy.de/project/ilcsoft/sw/x86_64_gcc49_sl6/${ILCSOFTVER}/init_ilcsoft.sh | ||
| . /afs/desy.de/project/ilcsoft/sw/x86_64_gcc131_el9/${ILCSOFTVER}/init_ilcsoft.sh |
Contributor
There was a problem hiding this comment.
I suppose you would do this on Key4hep in the end? Does that also work? From a quick look, it seems like ILCSOFTVER is used for creating some output directories as well(?)
Contributor
Author
There was a problem hiding this comment.
This PR is intended to be the minimal change to get the code to run (+formatting). It did work in key4hep as well, but I suggest to put this in another PR
Contributor
Author
I do not know |
Contributor
|
Anything still missing from this one? If not, I would merge. |
Contributor
Author
|
Should be complete. Feel free to merge it |
This reverts commit 788496c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
RHEL 9andILCSOFT v02-03-04Resultsfolder and not somewhere in the home dirENDRELEASENOTES