Skip to content

Format cpp,h,C files#48

Open
Victor-Schwan wants to merge 3 commits into
iLCSoft:masterfrom
Victor-Schwan:fmt-macros
Open

Format cpp,h,C files#48
Victor-Schwan wants to merge 3 commits into
iLCSoft:masterfrom
Victor-Schwan:fmt-macros

Conversation

@Victor-Schwan
Copy link
Copy Markdown
Contributor

BEGINRELEASENOTES

  • Add a .clang-format file using the LLVM style
  • Format all .cpp, .C and .h files
  • Add formatting commit hashes to .git-blame-ignore-revs

ENDRELEASENOTES

@jmcarcell
Copy link
Copy Markdown
Contributor

Why separate formatting macros and files? Can you putt all formatting in the same commit?
For the .clang-format did you pick the Key4hep one? We never decided anything for iLCSoft, but it would make it somewhat consistent (even if the format that has been used in the past in iLCSoft repositories is different). If one day we decide to have a common .clang-format in iLCSoft repositories then no extra formatting would be needed.

@Victor-Schwan
Copy link
Copy Markdown
Contributor Author

At first, I wanted to format the macros and only then I realized that I probably should format every relevant file in the repository. Ofc I can combine the commits.
I have used the LLVM style but I am fine with using which ever style you prefer. Assuming that the key4hep style is consistent in all repos, I would just copy the one from key4hep/k4FWCore, ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants