Skip to content

Simplify the way the command are built#14

Merged
tetienne merged 3 commits intomasterfrom
enhancement/send_command
Jul 20, 2020
Merged

Simplify the way the command are built#14
tetienne merged 3 commits intomasterfrom
enhancement/send_command

Conversation

@tetienne
Copy link
Copy Markdown
Collaborator

@tetienne tetienne commented Jul 20, 2020 •
edited
Loading

Fix #10

Example usage:

device_url = 'io://xxxxx/
await client.send_command(device_url,  Command("setPosition", [23]))
await client.send_command(device_url, "close")

@tetienne tetienne requested review from iMicknl and vlebourl July 20, 2020 11:45
tetienne
tetienne commented Jul 20, 2020
View reviewed changes
Comment thread tahoma_api/client.py
tetienne
tetienne commented Jul 20, 2020
View reviewed changes
Comment thread tahoma_api/models.py
tetienne
tetienne commented Jul 20, 2020
View reviewed changes
Comment thread tahoma_api/client.py
tetienne
tetienne commented Jul 20, 2020
View reviewed changes
Comment thread tahoma_api/client.py
tetienne
tetienne commented Jul 20, 2020
View reviewed changes
Comment thread tahoma_api/models.py
@tetienne tetienne force-pushed the enhancement/send_command branch from a7674a1 to 6acabb2 Compare July 20, 2020 11:55
tetienne
tetienne commented Jul 20, 2020
View reviewed changes
Comment thread tahoma_api/client.py Outdated
@tetienne tetienne force-pushed the enhancement/send_command branch from 6acabb2 to 409c370 Compare July 20, 2020 13:21
@tetienne tetienne merged commit 3ebdd64 into master Jul 20, 2020
@tetienne tetienne deleted the enhancement/send_command branch July 20, 2020 13:48
@philippabele philippabele mentioned this pull request Apr 7, 2021
Closed
tetienne added a commit that referenced this pull request Feb 14, 2023
@tetienne
Simplify the way the command are built (#14)
63cb952
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iMicknl iMicknl iMicknl approved these changes

@vlebourl vlebourl Awaiting requested review from vlebourl

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rework execute_action_group

2 participants

@tetienne @iMicknl