Create a States class to ease state access#17
Merged
Conversation
iMicknl
approved these changes
Jul 24, 2020
Owner
iMicknl
left a comment
There was a problem hiding this comment.
Great improvement! Would be good to also do this for CommandDefinition as well.
And my personal preference is to have a .get() function.
Collaborator
Author
|
@iMicknl Code updated, you should like :) |
Owner
LGTM! I see you marked it as a draft, so I will let you merge it yourself when you are ready :). |
Collaborator
Author
|
Yes I saw a potential issue for the command in operator. I have to check. |
Owner
|
@tetienne we should pin the version in the component and bump it here. Now an update to master can break the component. Looks like it did now? |
tetienne
added a commit
that referenced
this pull request
Feb 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow this kind of syntax: