use explicit assertions following Python idioms#2013
Merged
Conversation
…conftest.py Centralizes reusable test infrastructure in a shared conftest module, removing duplication from test_client.py and adding type hints.
Replace `assert x` / `assert not x` with `assert x is not None` / `assert x is None` where the intent is to check for None, not falsiness.
Replace `assert state.value_as_X` inside `pytest.raises()` blocks with `_ = state.value_as_X` to avoid misleading assert-inside-raises and satisfy B018 (useless expression) lint rule.
tetienne
approved these changes
Apr 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the test suite to use more explicit, idiomatic Python assertions and consolidates shared test utilities/fixtures to align with feedback from #1916.
Changes:
- Replace truthiness-based assertions with explicit
is None/is not Nonechecks in multiple tests. - Move shared test helpers/fixtures (e.g.,
MockResponse,client,local_client) intotests/conftest.py. - Adjust exception tests to explicitly trigger property access inside
pytest.raises(...).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
tests/test_utils.py |
Switches local server config assertions to explicit is not None. |
tests/test_models.py |
Uses explicit None/non-None assertions and simplifies exception assertions. |
tests/test_client.py |
Removes inline fixtures and uses shared MockResponse; makes assertions more explicit. |
tests/conftest.py |
Adds shared MockResponse helper and async client/local_client fixtures. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply feedback from #1916