Add unregister endpoint and automatically unregister on close#25
Merged
Add unregister endpoint and automatically unregister on close#25
Conversation
tetienne
reviewed
Jul 29, 2020
tetienne
reviewed
Jul 29, 2020
tetienne
reviewed
Jul 29, 2020
tetienne
reviewed
Jul 29, 2020
| response = await self.__post("events/register") | ||
| listener_id = response.get("id") | ||
| self.event_listener = listener_id | ||
| self.event_listener_id = listener_id |
Collaborator
There was a problem hiding this comment.
IMO the variable listener_id is useless. But it's ok.
Owner
Author
There was a problem hiding this comment.
@tetienne I agree. However linter was complaining about the fact that it could be str or None. Instead of str.
Is there a way to annotate that response.get("id") will return a string always
Collaborator
There was a problem hiding this comment.
.get will return None if the key can not be found. Try with response["id"].
Owner
Author
There was a problem hiding this comment.
@tetienne same. I will keep it like this for now.
tahoma_api/client.py:111: error: Incompatible return value type (got "Optional[str]", expected "str")
tetienne
approved these changes
Jul 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.