Merged
Conversation
add support for dynamically adding state to States.
vlebourl
added a commit
to iMicknl/ha-tahoma
that referenced
this pull request
Aug 3, 2020
…mically added later. relates to: #197 requires: iMicknl/python-overkiz-api#29
tetienne
reviewed
Aug 3, 2020
tetienne
reviewed
Aug 3, 2020
tetienne
reviewed
Aug 3, 2020
iMicknl
reviewed
Aug 3, 2020
tetienne
reviewed
Aug 3, 2020
vlebourl
added a commit
to iMicknl/ha-tahoma
that referenced
this pull request
Aug 5, 2020
* Some states are missing at init in tahoma's response, it must be dynamically added later. relates to: #197 requires: iMicknl/python-overkiz-api#29 * Add support for property hvac_action. Report whether the heater is idle or heating. * fix missing test * Update custom_components/tahoma/coordinator.py Co-authored-by: Thibaut <thibaut@etienne.pw> * apply comment * Add dependency to pyhoma 0.3.0. Co-authored-by: Thibaut <thibaut@etienne.pw>
tetienne
pushed a commit
that referenced
this pull request
Feb 14, 2023
* dynamic state addition add support for dynamically adding state to States. * apply black and comments. * Add missing DataType. * default value to None in State. * simplified append * apply comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add support for dynamically adding state to States.
add support for default value to None